Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module is not working with react and react-dom 16.4.0 #19

Open
vinodloha opened this issue Jul 9, 2018 · 3 comments
Open

Module is not working with react and react-dom 16.4.0 #19

vinodloha opened this issue Jul 9, 2018 · 3 comments

Comments

@vinodloha
Copy link

There is an error for missing reference of following 2 references.

const InstantiateReactComponent = require("react-dom/lib/instantiateReactComponent");
const escapeTextContentForBrowser = require("react-dom/lib/escapeTextContentForBrowser");

Is it possible for you guys to update this package for react and react-dom 16.4.0?
I am also happy to raise a PR.

@yangchongduo
Copy link

@vinodloha For everyone, let me mention one.

@angelomichel
Copy link

Also interested in a solution for this one! :)

@dtuyenle
Copy link

dtuyenle commented Feb 20, 2019

react-dom 16x changes their internal API completely. And It is not recommended to use internal API for any development cause then you have to update these changes when you upgrade dependencies version. This approach feels like a hack.

One option is to use react-dom-core and update these 2 imports to react-dom-core/lib/instantiateReactComponent But this won't work either since you are not intercepting the rendering since react-dom 16 not using instantiateReactComponent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants