Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not running prettier GH Action in unrelated changes #1994

Closed
egekorkan opened this issue Apr 3, 2024 · 0 comments · Fixed by #1998
Closed

Not running prettier GH Action in unrelated changes #1994

egekorkan opened this issue Apr 3, 2024 · 0 comments · Fixed by #1998
Assignees
@egekorkan
Labels
pipeline automation, actions, convenience scripts

Comments

@egekorkan
Copy link
Contributor

egekorkan commented Apr 3, 2024 •
edited
Loading

There are paths ignored by prettier as by https://github.com/w3c/wot-thing-description/blob/main/.prettierignore . However, a GH Action will still run and waste time. We should simply align the action to ignore the same way.
@egekorkan egekorkan self-assigned this Apr 3, 2024
@github-actions github-actions bot added the needs-triage Automatically added to new issues. TF should triage them with proper labels label Apr 3, 2024
@egekorkan egekorkan added pipeline automation, actions, convenience scripts and removed needs-triage Automatically added to new issues. TF should triage them with proper labels labels Apr 3, 2024
@egekorkan egekorkan mentioned this issue Apr 3, 2024
Merged
@egekorkan egekorkan changed the title Not run prettier in unrelated changes Not running prettier GH Action in unrelated changes Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egekorkan egekorkan

Labels
pipeline automation, actions, convenience scripts
Projects
None yet
Milestone
No milestone
1 participant
@egekorkan