Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies in wotsec ontology #1909

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Inconsistencies in wotsec ontology #1909

merged 3 commits into from
Oct 25, 2023

Conversation

mahdanoura
Copy link
Contributor

fixes #1908

@mahdanoura mahdanoura requested a review from mmccool October 25, 2023 08:09
@egekorkan
Copy link
Contributor

egekorkan commented Oct 25, 2023 •
edited
Loading

I have tried it locally and there are some things to note:

  • The figure doesn't change since we are using static pngs at the moment.
  • There is a change in the HTML version (which is normal but not pushed?)

@mahdanoura
Copy link
Contributor Author

I have tried it locally and there are some things to note:

  • The figure doesn't change since we are using static pngs at the moment.
  • There is a change in the HTML version (which is normal but not pushed?)

The SVGs change and not the static pngs, there is also a change in the wotsec.html

@egekorkan egekorkan added the Editorial Issues with no technical impact on implementations label Oct 25, 2023
@egekorkan
Copy link
Contributor

Call of 25.10: We will merge this PR. The rest of the figure related issues will be done later.

@egekorkan egekorkan merged commit 8c96e10 into w3c:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmccool mmccool Awaiting requested review from mmccool

Assignees
No one assigned
Labels
Editorial Issues with no technical impact on implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistencies in wotsec ontology
2 participants
@mahdanoura @egekorkan