Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspect-ratio not working #366

Open
EmpireJones opened this issue Apr 29, 2022 · 2 comments
Open

aspect-ratio not working #366

EmpireJones opened this issue Apr 29, 2022 · 2 comments
Assignees
Labels

Comments

@EmpireJones
Copy link

I'm not 100% sure that this syntax is valid, but some tool I'm using is converting "aspect-ratio: 3000 / 3000;" to "aspect-ratio:3e3/3e3".

This results in the errors:

  • "aspect-ratio": Unknown dimension.
  • "aspect-ratio": "/" is not a "aspect-ratio" value.

According to https://developer.mozilla.org/en-US/docs/Web/CSS/number, scientific notation should be valid for CSS numbers.

@EmpireJones
Copy link
Author

It looks like this functionality is pretty broken in general;

As mentioned in the following comment, even things like "aspect-ratio:1;" and "aspect-ratio:1.5;" don't validate properly.
#287 (comment)

@ylafon
Copy link
Member

ylafon commented Apr 9, 2024

The second part (aspect-ratio with one number only) has been fixed by ad4b711. The number parsing needs to be addressed.

@ylafon ylafon self-assigned this Apr 9, 2024
@ylafon ylafon added the bug label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants