Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add option to scope vuetify-theme-stylesheet styles #4065

Open
calebbergman opened this issue May 15, 2018 · 1 comment · May be fixed by #20789
Open

[Feature Request] Add option to scope vuetify-theme-stylesheet styles #4065

calebbergman opened this issue May 15, 2018 · 1 comment · May be fixed by #20789
Labels
E: theme Theme composable T: feature A new feature

Comments

@calebbergman
Copy link

Problem to solve

Webpack + postcss has been working pretty well for us, giving us the ability to scope any and all css in any given app to a specific selector, including the main Vuetify stylesheet. We noticed, however, that vuetify generates a stylesheet at run-time with an id of "vuetify-theme-stylesheet." Unfortunately this bypasses our postcss config at build-time and thus overwrites any existing styles with the same name.

Proposed solution

Add the ability to scope the "vuetify-theme-stylesheet" stylesheet to a specific selector. Perhaps an option during...

Vue.use(Vuetify, {
   options: { ...
      scope: '#my-app'
    }
})

Ideally we wouldn't need to declare the selector twice (once in our postcss config and another in Vue.use()).

@nekosaur nekosaur added the pending review The issue is still pending disposition label May 17, 2018
@KaelWD KaelWD added wontfix The issue is expected and will not be fixed and removed pending review The issue is still pending disposition labels Jun 16, 2018
@KaelWD
Copy link
Member

KaelWD commented Jun 16, 2018

If you want to do this you'll have to extract the stylesheet manually then disable generation with theme: false

@KaelWD KaelWD closed this as completed Jun 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 16, 2019
@KaelWD KaelWD reopened this Dec 19, 2024
@vuetifyjs vuetifyjs unlocked this conversation Dec 19, 2024
@KaelWD KaelWD added T: feature A new feature E: theme Theme composable and removed wontfix The issue is expected and will not be fixed labels Dec 19, 2024
@KaelWD KaelWD added this to the v3.8.0 (Andromeda) milestone Dec 19, 2024
@KaelWD KaelWD linked a pull request Dec 19, 2024 that will close this issue
@KaelWD KaelWD linked a pull request Dec 19, 2024 that will close this issue
DerYeger added a commit to DerYeger/vuetify that referenced this issue Dec 19, 2024
DerYeger added a commit to DerYeger/vuetify that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: theme Theme composable T: feature A new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants