Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.5.5] VSparkline has incorrect types for properties "smooth" and "labels" #19262

Closed
ristokyotikki opened this issue Feb 23, 2024 · 1 comment · May be fixed by #20795
Closed

[Bug Report][3.5.5] VSparkline has incorrect types for properties "smooth" and "labels" #19262

ristokyotikki opened this issue Feb 23, 2024 · 1 comment · May be fixed by #20795
Labels
C: VSparkline VSparkline T: bug Functionality that does not work as intended/expected

Comments

@ristokyotikki
Copy link

Environment

Vuetify Version: 3.5.5
Vue Version: 3.4.14
Browsers: Chrome 121.0.0.0
OS: Linux x86_64

Steps to reproduce

Open link, see warnings for values that have types which should be supported per docs and expected behaviour.

Expected Behavior

  • Smooth property does not give warning if given value is of type number
  • Labels property does not give warning if given value is of type string[]

Actual Behavior

  • Type warnings thrown for supported types on properties smooth and labels

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

@mbegerau
Copy link

mbegerau commented Jun 6, 2024

I can confirm that this problem still exists with version 3.8.6. But now the erroneous type declarations are in the file: vuetify/packages/vuetify/src/components/VSparkline/util/line.ts

labels
smooth

@github-actions github-actions bot added the S: stale This issue is untriaged and hasn't seen any activity in at least six months. label Dec 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
@J-Sek J-Sek added T: bug Functionality that does not work as intended/expected C: VSparkline VSparkline and removed S: triage S: stale This issue is untriaged and hasn't seen any activity in at least six months. labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VSparkline VSparkline T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants