Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose VPFeatures #4355

Open
4 tasks done
florian-sattler opened this issue Nov 12, 2024 · 2 comments · May be fixed by #4356
Open
4 tasks done

Expose VPFeatures #4355

florian-sattler opened this issue Nov 12, 2024 · 2 comments · May be fixed by #4356

Comments

@florian-sattler
Copy link
Contributor

Is your feature request related to a problem? Please describe.

As a user, I want to use the VPFeatures component on any page at any location I want, as it is a very useful as well as highly encapsulated component. However, currently only VPHomeFeatures is exposed, which is only a thin wrapper around VPFeatures that just ensures frontmatter is used for parametrization. This prevents using this otherwise standalone component freely.

Describe the solution you'd like

Add VPFeatures to vitepress/theme.d.ts e.g. by modifying either src/client/theme-default/index.ts or src/client/theme-default/without-fonts.ts.

Describe alternatives you've considered

Trying to use only the related classes does not work due to the scoped styles. Other ideas have failed, similar to the issues described in #2595.

Additional context

No response

Validations
florian-sattler pushed a commit to florian-sattler/vitepress that referenced this issue Nov 12, 2024
@FlorianSattlerCS
feat(theme): expose VPFeatures
ff90806 
close vuejs#4355
florian-sattler added a commit to florian-sattler/vitepress that referenced this issue Nov 12, 2024
@florian-sattler
feat(theme): expose VPFeatures\n\nclose vuejs#4355
9a73ab5
florian-sattler added a commit to florian-sattler/vitepress that referenced this issue Nov 12, 2024
@florian-sattler
feat(theme): expose VPFeatures
e0659b9 
close vuejs#4355
@florian-sattler florian-sattler linked a pull request Nov 12, 2024 that will close this issue
Open
@florian-sattler
Copy link
Contributor Author

I've added a possible solution in the form of a pull request. However, I'm happy to iterate on this if desired.

@florian-sattler
Copy link
Contributor Author

@brc-dd Do you have any opinions on this? You've been actively involved in the related issue, and your insight would be very appreciated 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theme): expose VPFeatures florian-sattler/vitepress
1 participant
@florian-sattler