-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-core): handle prop starts with on, but is not an event handler #7872
base: main
Are you sure you want to change the base?
Conversation
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some similar special cases that might also be worth considering:
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Size ReportBundles
Usages
|
I think there's a problem here with merging arrays of listeners. e.g.: Listener |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
@vue/compat
vue
commit: |
close #7871
This is an edge case where the user uses on-xxx as a
prop
not aneventHandler
, andmergeProps
treats it as an event listener. This PR modifies the merging logic only to treat it as an event listener if the prop's value is a function.