Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UcanBuilder::with_expiration should take Option<u64> instead of u64 #114

Open
cdata opened this issue Jun 30, 2023 · 0 comments
Open

UcanBuilder::with_expiration should take Option<u64> instead of u64 #114

cdata opened this issue Jun 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@cdata
Copy link
Member

cdata commented Jun 30, 2023

Now that we can express a never-expiring UCAN via None for exp, the UcanBuilder::with_expiration method should accept Option<u64> so that a user can express a never expiring with builder.with_expiration(None).
@cdata cdata added the enhancement New feature or request label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cdata