Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Safari/12602.2.14.0.7 CFNetwork/807.1.3 Darwin/16.1.0 (x86_64) failing #238

Closed
F21 opened this issue Apr 20, 2017 · 3 comments
Closed

Comments

@F21
Copy link

F21 commented Apr 20, 2017

I updated the Go library to the latest commit (5dceb89): ua-parser/uap-go#41

Unfortunately, the test is failing for this UA: Safari/12602.2.14.0.7 CFNetwork/807.1.3 Darwin/16.1.0 (x86_64):

got uaparser.Device{Family:"iOS-Device", Brand:"Apple", Model:"iOS-Device"}
want uaparser.Device{Family:"Other", Brand:"", Model:""}

I am not sure if this is an issue with uap-core (all tests appear to be passing here) or an issue with the go library.

@elsigh
Copy link
Contributor

elsigh commented Apr 20, 2017

This seems like it must then be an issue in the Go library, perhaps related to ua-parser/uap-go#33?

@F21
Copy link
Author

F21 commented Apr 20, 2017

@elsigh That might be the cause! I'll take a look at it when I find some time and will close this issue.

@Plasma
Copy link

Plasma commented Apr 26, 2017

@elsigh I'd like to point out ua-parser/uap-csharp#23 which has failures as well due to the recent additions of at least one of the regexes to the core yaml file.

See https://github.com/ua-parser/uap-core/pull/230/files#r113348068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants