Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding checkstyle & code coverage verification #36

Open
snigdhasjg opened this issue Apr 30, 2023 · 1 comment
Open

Adding checkstyle & code coverage verification #36

snigdhasjg opened this issue Apr 30, 2023 · 1 comment

Comments

@snigdhasjg
Copy link
Contributor

Description

  1. As development goes, uniform coding style plays big role in maintenance.
  2. Automated checks on code coverage

Steps to reproduce

Expected Behavior

  1. Having a checkstyle in place so its easy to contribute, local IDE setup doesn't hamper.
  2. Having a .editorconfig in place so IDE automatically formats according to coding style
  3. Tests need to be verified and coverage published (could be as a badge, thinking out loud)
    Note: Initially we can't fail build if coverage goes beyond X%. Once tests are fixed, will have the check in pipeline

Actual Behavior

  1. Many unoptimized imports
  2. Unit tests doing nothing other than printing

Metadata

NA

Typesense Version: NA

OS: NA

@R-Sandor
Copy link

Have you guys considered something like https://github.com/diffplug/spotless?

Checkstyle is still very good though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants