Since v2.5.0 `fs2-grpc-runtime_2.13-2.5.0.jar` is actually a Scala 3 artifact ... #620

armanbilge · 2023-05-10T19:41:25Z

$ wget https://repo1.maven.org/maven2/org/typelevel/fs2-grpc-runtime_2.13/2.5.0/fs2-grpc-runtime_2.13-2.5.0.jar
$ less fs2-grpc-runtime_2.13-2.5.0.jar
Archive:  fs2-grpc-runtime_2.13-2.5.0.jar
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
     378  Defl:N      172  55% 2010-01-01 00:00 94f392f2  META-INF/MANIFEST.MF
       0  Stored        0   0% 2010-01-01 00:00 00000000  fs2/
       0  Stored        0   0% 2010-01-01 00:00 00000000  fs2/grpc/
       0  Stored        0   0% 2010-01-01 00:00 00000000  fs2/grpc/client/
       0  Stored        0   0% 2010-01-01 00:00 00000000  fs2/grpc/client/internal/
       0  Stored        0   0% 2010-01-01 00:00 00000000  fs2/grpc/server/
       0  Stored        0   0% 2010-01-01 00:00 00000000  fs2/grpc/server/internal/
       0  Stored        0   0% 2010-01-01 00:00 00000000  fs2/grpc/shared/
       0  Stored        0   0% 2010-01-01 00:00 00000000  fs2/grpc/syntax/
   26158  Defl:N     8521  67% 2010-01-01 00:00 bdb1e81a  fs2/grpc/GeneratedCompanion.class
    9703  Defl:N     4710  52% 2010-01-01 00:00 9291ba4a  fs2/grpc/GeneratedCompanion.tasty
     868  Defl:N      443  49% 2010-01-01 00:00 88982cd1  fs2/grpc/client/ClientOptions$$anon$1.class
    1223  Defl:N      633  48% 2010-01-01 00:00 4d611eca  fs2/grpc/client/ClientOptions$$anon$2$$anonfun$$lessinit$greater$1.class
     756  Defl:N      422  44% 2010-01-01 00:00 a706632c  fs2/grpc/client/ClientOptions$$anon$2.class
     699  Defl:N      399  43% 2010-01-01 00:00 6a90e8c5  fs2/grpc/client/ClientOptions$.class
    4516  Defl:N     2139  53% 2010-01-01 00:00 bac4f99e  fs2/grpc/client/ClientOptions.class
    2597  Defl:N     1955  25% 2010-01-01 00:00 39629ff1  fs2/grpc/client/ClientOptions.tasty
    2987  Defl:N     1278  57% 2010-01-01 00:00 f926f28a  fs2/grpc/client/Fs2ClientCall$$anon$1.class
    3309  Defl:N     1420  57% 2010-01-01 00:00 d47be9cb  fs2/grpc/client/Fs2ClientCall$$anonfun$1.class
     840  Defl:N      463  45% 2010-01-01 00:00 ce33fdf0  fs2/grpc/client/Fs2ClientCall$.class
    4141  Defl:N     1637  61% 2010-01-01 00:00 45d49021  fs2/grpc/client/Fs2ClientCall$PartiallyAppliedClientCall$.class
    2168  Defl:N      873  60% 2010-01-01 00:00 053a0c2c  fs2/grpc/client/Fs2ClientCall$PartiallyAppliedClientCall.class
   21359  Defl:N     9151  57% 2010-01-01 00:00 523674d6  fs2/grpc/client/Fs2ClientCall.class
    9457  Defl:N     6620  30% 2010-01-01 00:00 7bd035c5  fs2/grpc/client/Fs2ClientCall.tasty
    3097  Defl:N     1246  60% 2010-01-01 00:00 06e94f6b  fs2/grpc/client/Fs2StreamClientCallListener$.class
    4587  Defl:N     2510  45% 2010-01-01 00:00 909972ad  fs2/grpc/client/Fs2StreamClientCallListener.class
    2832  Defl:N     2195  23% 2010-01-01 00:00 8b43260a  fs2/grpc/client/Fs2StreamClientCallListener.tasty
    2077  Defl:N      939  55% 2010-01-01 00:00 173a4d4f  fs2/grpc/client/GrpcStatus$.class
    5394  Defl:N     2812  48% 2010-01-01 00:00 89331d27  fs2/grpc/client/GrpcStatus.class
    2555  Defl:N     2002  22% 2010-01-01 00:00 a79aec69  fs2/grpc/client/GrpcStatus.tasty
    6710  Defl:N     2915  57% 2010-01-01 00:00 10c5a9bc  fs2/grpc/client/StreamIngest$$anon$1.class
    3312  Defl:N     1304  61% 2010-01-01 00:00 4a412ea8  fs2/grpc/client/StreamIngest$.class
    2801  Defl:N     1633  42% 2010-01-01 00:00 82b56a98  fs2/grpc/client/StreamIngest.class
    4553  Defl:N     3284  28% 2010-01-01 00:00 3986b59d  fs2/grpc/client/StreamIngest.tasty
    1814  Defl:N      843  54% 2010-01-01 00:00 e7aec1b7  fs2/grpc/client/UnaryResult$.class
    5747  Defl:N     2872  50% 2010-01-01 00:00 1b0c0dd2  fs2/grpc/client/UnaryResult.class
    2753  Defl:N     2190  21% 2010-01-01 00:00 3c8221e5  fs2/grpc/client/UnaryResult.tasty
    6401  Defl:N     2318  64% 2010-01-01 00:00 77017245  fs2/grpc/client/internal/Fs2UnaryCallHandler$$anon$1.class
   12712  Defl:N     4410  65% 2010-01-01 00:00 f7674de7  fs2/grpc/client/internal/Fs2UnaryCallHandler$.class
     693  Defl:N      357  49% 2010-01-01 00:00 dec7bd61  fs2/grpc/client/internal/Fs2UnaryCallHandler$Done.class
    3764  Defl:N     1387  63% 2010-01-01 00:00 f304d53d  fs2/grpc/client/internal/Fs2UnaryCallHandler$PendingHalfClose.class
    3443  Defl:N     1289  63% 2010-01-01 00:00 5099df1c  fs2/grpc/client/internal/Fs2UnaryCallHandler$PendingMessage.class
    4314  Defl:N     1813  58% 2010-01-01 00:00 401a9b84  fs2/grpc/client/internal/Fs2UnaryCallHandler$ReceiveState$.class
     359  Defl:N      224  38% 2010-01-01 00:00 9e067ae4  fs2/grpc/client/internal/Fs2UnaryCallHandler$ReceiveState.class
    4818  Defl:N     2855  41% 2010-01-01 00:00 2c74d8e1  fs2/grpc/client/internal/Fs2UnaryCallHandler.class
   10777  Defl:N     6996  35% 2010-01-01 00:00 a4124994  fs2/grpc/client/internal/Fs2UnaryCallHandler.tasty
    8422  Defl:N     2814  67% 2010-01-01 00:00 5d28ae79  fs2/grpc/server/Fs2ServerCall$.class
    7238  Defl:N     3212  56% 2010-01-01 00:00 19f073ac  fs2/grpc/server/Fs2ServerCall.class
    2990  Defl:N     2189  27% 2010-01-01 00:00 f62f6498  fs2/grpc/server/Fs2ServerCall.tasty
    3988  Defl:N     1545  61% 2010-01-01 00:00 e6999ba5  fs2/grpc/server/Fs2ServerCallHandler$$anon$1.class
    5945  Defl:N     2272  62% 2010-01-01 00:00 4fcf6b7d  fs2/grpc/server/Fs2ServerCallHandler$$anon$2.class
    1200  Defl:N      552  54% 2010-01-01 00:00 0cfb8005  fs2/grpc/server/Fs2ServerCallHandler$.class
    5014  Defl:N     2247  55% 2010-01-01 00:00 b4af0386  fs2/grpc/server/Fs2ServerCallHandler.class
    4876  Defl:N     3356  31% 2010-01-01 00:00 dbd3bf76  fs2/grpc/server/Fs2ServerCallHandler.tasty
   11045  Defl:N     4844  56% 2010-01-01 00:00 413cc082  fs2/grpc/server/Fs2ServerCallListener.class
    5443  Defl:N     3717  32% 2010-01-01 00:00 63219539  fs2/grpc/server/Fs2ServerCallListener.tasty
     948  Defl:N      471  50% 2010-01-01 00:00 cc9f4733  fs2/grpc/server/Fs2StreamServerCallListener$.class
    7887  Defl:N     2689  66% 2010-01-01 00:00 f01e0e65  fs2/grpc/server/Fs2StreamServerCallListener$PartialFs2StreamServerCallListener$.class
    2305  Defl:N      898  61% 2010-01-01 00:00 a688881e  fs2/grpc/server/Fs2StreamServerCallListener$PartialFs2StreamServerCallListener.class
    8370  Defl:N     4311  49% 2010-01-01 00:00 077e0e45  fs2/grpc/server/Fs2StreamServerCallListener.class
    4960  Defl:N     3673  26% 2010-01-01 00:00 6348004c  fs2/grpc/server/Fs2StreamServerCallListener.tasty
    1743  Defl:N      835  52% 2010-01-01 00:00 430e63f7  fs2/grpc/server/GzipCompressor$.class
    2027  Defl:N     1241  39% 2010-01-01 00:00 6e6f1280  fs2/grpc/server/GzipCompressor.class
    1178  Defl:N      988  16% 2010-01-01 00:00 d72699fe  fs2/grpc/server/GzipCompressor.tasty
     762  Defl:N      407  47% 2010-01-01 00:00 b246a11c  fs2/grpc/server/ServerCallOptions$$anon$1.class
     578  Defl:N      346  40% 2010-01-01 00:00 1a655c75  fs2/grpc/server/ServerCallOptions$$anon$2.class
     723  Defl:N      408  44% 2010-01-01 00:00 a88ed152  fs2/grpc/server/ServerCallOptions$.class
    3080  Defl:N     1592  48% 2010-01-01 00:00 17b93fe3  fs2/grpc/server/ServerCallOptions.class
    1914  Defl:N     1464  24% 2010-01-01 00:00 0b7e3aa6  fs2/grpc/server/ServerCallOptions.tasty
    1905  Defl:N     1017  47% 2010-01-01 00:00 193d76a7  fs2/grpc/server/ServerCompressor.class
     605  Defl:N      557   8% 2010-01-01 00:00 a6c5ffdd  fs2/grpc/server/ServerCompressor.tasty
     704  Defl:N      374  47% 2010-01-01 00:00 a4dd9019  fs2/grpc/server/ServerOptions$$anon$1.class
    1307  Defl:N      637  51% 2010-01-01 00:00 0ebeb11c  fs2/grpc/server/ServerOptions$$anon$2$$anonfun$$lessinit$greater$1.class
     596  Defl:N      345  42% 2010-01-01 00:00 4ce7554b  fs2/grpc/server/ServerOptions$$anon$2.class
     699  Defl:N      399  43% 2010-01-01 00:00 769e3d24  fs2/grpc/server/ServerOptions$.class
    2174  Defl:N     1092  50% 2010-01-01 00:00 407a5aae  fs2/grpc/server/ServerOptions.class
    1390  Defl:N     1130  19% 2010-01-01 00:00 72d617b1  fs2/grpc/server/ServerOptions.tasty
    3643  Defl:N     1438  61% 2010-01-01 00:00 6af038df  fs2/grpc/server/internal/Fs2ServerCall$.class
   12928  Defl:N     5715  56% 2010-01-01 00:00 b19c28ea  fs2/grpc/server/internal/Fs2ServerCall.class
    6258  Defl:N     4441  29% 2010-01-01 00:00 8abd7c48  fs2/grpc/server/internal/Fs2ServerCall.tasty
    6365  Defl:N     2340  63% 2010-01-01 00:00 d346044e  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$$anon$1.class
    4729  Defl:N     1689  64% 2010-01-01 00:00 7f124930  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$$anon$2.class
    5582  Defl:N     1964  65% 2010-01-01 00:00 73853496  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$$anon$3.class
    6901  Defl:N     2026  71% 2010-01-01 00:00 037543c2  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$.class
    2000  Defl:N      844  58% 2010-01-01 00:00 5834be38  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$Called$.class
    3615  Defl:N     1360  62% 2010-01-01 00:00 1983929d  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$Called.class
    2151  Defl:N      911  58% 2010-01-01 00:00 c490c947  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$CallerState$.class
     375  Defl:N      225  40% 2010-01-01 00:00 f13d191e  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$CallerState.class
    1663  Defl:N      711  57% 2010-01-01 00:00 8923a4ec  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$Cancelled$.class
    2783  Defl:N     1083  61% 2010-01-01 00:00 3b337394  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$Cancelled.class
    2374  Defl:N      947  60% 2010-01-01 00:00 061e8992  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$PendingHalfClose$.class
    5785  Defl:N     2040  65% 2010-01-01 00:00 282dd7da  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$PendingHalfClose.class
    2158  Defl:N      874  60% 2010-01-01 00:00 521c4d1c  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$PendingMessage$.class
    4304  Defl:N     1507  65% 2010-01-01 00:00 c69995a3  fs2/grpc/server/internal/Fs2UnaryServerCallHandler$PendingMessage.class
    8176  Defl:N     4915  40% 2010-01-01 00:00 407a535a  fs2/grpc/server/internal/Fs2UnaryServerCallHandler.class
   12975  Defl:N     8194  37% 2010-01-01 00:00 9b8343d3  fs2/grpc/server/internal/Fs2UnaryServerCallHandler.tasty
    5684  Defl:N     2027  64% 2010-01-01 00:00 906897ed  fs2/grpc/shared/StreamOutput$.class
    4410  Defl:N     2147  51% 2010-01-01 00:00 8c593f70  fs2/grpc/shared/StreamOutput.class
    3133  Defl:N     2302  27% 2010-01-01 00:00 d7d50a47  fs2/grpc/shared/StreamOutput.tasty
    7310  Defl:N     3312  55% 2010-01-01 00:00 196cacbe  fs2/grpc/shared/StreamOutputImpl.class
    2513  Defl:N     2031  19% 2010-01-01 00:00 c8d4e352  fs2/grpc/shared/StreamOutputImpl.tasty
     529  Defl:N      419  21% 2010-01-01 00:00 d42c7380  fs2/grpc/syntax/AllSyntax.class
     446  Defl:N      407   9% 2010-01-01 00:00 15fe2452  fs2/grpc/syntax/AllSyntax.tasty
    6146  Defl:N     2235  64% 2010-01-01 00:00 1f417534  fs2/grpc/syntax/ManagedChannelBuilderOps$.class
    6710  Defl:N     2962  56% 2010-01-01 00:00 e0e30bb4  fs2/grpc/syntax/ManagedChannelBuilderOps.class
    4489  Defl:N     2621  42% 2010-01-01 00:00 5a65c9c9  fs2/grpc/syntax/ManagedChannelBuilderOps.tasty
    1488  Defl:N      821  45% 2010-01-01 00:00 8ffcd525  fs2/grpc/syntax/ManagedChannelBuilderSyntax.class
     913  Defl:N      727  20% 2010-01-01 00:00 29cf613e  fs2/grpc/syntax/ManagedChannelBuilderSyntax.tasty
    5840  Defl:N     2223  62% 2010-01-01 00:00 be92400d  fs2/grpc/syntax/ServerBuilderOps$.class
    6385  Defl:N     2898  55% 2010-01-01 00:00 e8d8e03d  fs2/grpc/syntax/ServerBuilderOps.class
    4355  Defl:N     2586  41% 2010-01-01 00:00 5dbbee38  fs2/grpc/syntax/ServerBuilderOps.tasty
    1343  Defl:N      778  42% 2010-01-01 00:00 7295a4b1  fs2/grpc/syntax/ServerBuilderSyntax.class
     858  Defl:N      709  17% 2010-01-01 00:00 71266bf0  fs2/grpc/syntax/ServerBuilderSyntax.tasty
     421  Defl:N      297  30% 2010-01-01 00:00 e3cdcf88  fs2/grpc/syntax/package$.class
    1625  Defl:N      658  60% 2010-01-01 00:00 5081fafb  fs2/grpc/syntax/package$all$.class
    1171  Defl:N      541  54% 2010-01-01 00:00 37e7af5d  fs2/grpc/syntax/package$managedChannelBuilder$.class
    1055  Defl:N      530  50% 2010-01-01 00:00 6da1b50c  fs2/grpc/syntax/package$serverBuilder$.class
     902  Defl:N      641  29% 2010-01-01 00:00 c36bab10  fs2/grpc/syntax/package.class
    1070  Defl:N      855  20% 2010-01-01 00:00 3e0cc8a0  fs2/grpc/syntax/package.tasty
--------          -------  ---                            -------
  452249           218803  52%                            119 files

The text was updated successfully, but these errors were encountered:

ahjohannessen · 2023-05-11T08:17:56Z

@armanbilge oh oh :/ Do you know what is the cause?

mackenziestarr · 2023-05-11T16:06:58Z

hey @ahjohannessen could it be something in the release / CI process?

when i run sbt publishLocal i don't seem to get .tasty files

❯ git checkout v2.5.12
HEAD is now at 5e2ae15 Run prePR with sbt-typelevel
❯ sbt publishLocal
...
[info]  published fs2-grpc-runtime_2.13 to /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.12/jars/fs2-grpc-runtime_2.13.jar
❯ jar tf /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.12/jars/fs2-grpc-runtime_2.13.jar | grep tasty
❯ echo $?
1

ahjohannessen · 2023-05-12T07:44:58Z

@mackenziestarr It might well be something in CI, the publish command in the workflow is sbt tlCiRelease.

The project uses sbt-projectmatrix because ScalaPB related things use that. It could be some combination of sbt-typelevel settings and sbt-projectmatrix settings that cause this.

armanbilge · 2023-05-12T18:24:11Z

Could it be this?

Warn if project sets crossScalaVersions sbt/sbt-projectmatrix#80

ahjohannessen · 2023-05-13T06:42:55Z

@armanbilge that might well be it? :)

ahjohannessen · 2023-05-16T10:20:12Z

@armanbilge I have tried various permutations with crossScalaVersions and sbt-projectmatrix, but not had any luck to get it to work. Something is definitely wrong in the build.

mackenziestarr · 2023-06-02T12:49:26Z

@armanbilge @ahjohannessen played with this a bit more and I managed to get tlReleaseLocal to work correctly (produces only tasty files for the Scala 3 artifact) by doing sbt clean beforehand. I don't know why this would be the case but sharing in case it helps further debugging.

# clear local ivy cache
$ rm -rf  /home/mstarr/.ivy2/local/org.typelevel
# doing sbt clean before release command
$ sbt clean
$ sbt tlReleaseLocal
# looks good!
$ for i in 2.12 2.13 3; do (artifact=~/.ivy2/local/org.typelevel/fs2-grpc-runtime_$i/**/jars/fs2-grpc-runtime_$i.jar; echo $artifact; grep '.tasty' $artifact); done
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.12/2.5.12/jars/fs2-grpc-runtime_2.12.jar
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.12/jars/fs2-grpc-runtime_2.13.jar
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.12/jars/fs2-grpc-runtime_3.jar
grep: /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.12/jars/fs2-grpc-runtime_3.jar: binary file matches
# clear local ivy cache, again
$ rm -rf  /home/mstarr/.ivy2/local/org.typelevel
# run without sbt clean
$ sbt tlReleaseLocal
# oops, all scala 3
$ for i in 2.12 2.13 3; do (artifact=~/.ivy2/local/org.typelevel/fs2-grpc-runtime_$i/**/jars/fs2-grpc-runtime_$i.jar; echo $artifact; grep '.tasty' $artifact); done
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.12/2.5.12/jars/fs2-grpc-runtime_2.12.jar
grep: /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.12/2.5.12/jars/fs2-grpc-runtime_2.12.jar: binary file matches
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.12/jars/fs2-grpc-runtime_2.13.jar
grep: /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.12/jars/fs2-grpc-runtime_2.13.jar: binary file matches
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.12/jars/fs2-grpc-runtime_3.jar
grep: /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.12/jars/fs2-grpc-runtime_3.jar: binary file matches

ahjohannessen · 2023-06-02T15:35:16Z

@mackenziestarr I tried changing the publish command to sbt clean tlCiRelease but that does not work. Just published 2.7.0 and 2.13 artifacts still contain tasty files.

Looking at the publish logs makes me think that something is off.

mackenziestarr · 2023-06-05T17:34:02Z

hey @ahjohannessen sorry to hear that, i was hopeful 🤞 - I played with this some more and think I may be on to something with this patch

https://gist.github.com/mackenziestarr/2dce93557cb27c667289cef19c23eb77

It should probably be cleaned up a bit but I was able to run multiple invocations of sbt tlReleaseLocal and only get tasty files in the scala 3 artifacts

$ for i in 2.12 2.13 3; do (artifact=~/.ivy2/local/org.typelevel/fs2-grpc-runtime_$i/**/jars/fs2-grpc-runtime_$i.jar; echo $artifact; grep '.tasty' $artifact); done
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.12/2.5.11-8-5e2ae15-20230605T172700Z-SNAPSHOT/jars/fs2-grpc-runtime_2.12.jar 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.12/2.5.11-8-5e2ae15-20230605T172730Z-SNAPSHOT/jars/fs2-grpc-runtime_2.12.jar 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.12/2.5.11-8-5e2ae15-20230605T172804Z-SNAPSHOT/jars/fs2-grpc-runtime_2.12.jar
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.11-8-5e2ae15-20230605T172708Z-SNAPSHOT/jars/fs2-grpc-runtime_2.13.jar 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.11-8-5e2ae15-20230605T172740Z-SNAPSHOT/jars/fs2-grpc-runtime_2.13.jar 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.11-8-5e2ae15-20230605T172814Z-SNAPSHOT/jars/fs2-grpc-runtime_2.13.jar
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.11-8-5e2ae15-20230605T172711Z-SNAPSHOT/jars/fs2-grpc-runtime_3.jar 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.11-8-5e2ae15-20230605T172743Z-SNAPSHOT/jars/fs2-grpc-runtime_3.jar 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.11-8-5e2ae15-20230605T172817Z-SNAPSHOT/jars/fs2-grpc-runtime_3.jar
grep: /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.11-8-5e2ae15-20230605T172711Z-SNAPSHOT/jars/fs2-grpc-runtime_3.jar: binary file matches
grep: /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.11-8-5e2ae15-20230605T172743Z-SNAPSHOT/jars/fs2-grpc-runtime_3.jar: binary file matches
grep: /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.11-8-5e2ae15-20230605T172817Z-SNAPSHOT/jars/fs2-grpc-runtime_3.jar: binary file matches

maybe you can try it with sbt tlCiRelease? (happy to try it myself but not really sure how to set up a test env)

armanbilge · 2023-06-05T17:36:55Z

That patch looks reasonable to me, it fixes the problem I suspected in #620 (comment).

mackenziestarr · 2023-06-05T17:40:40Z

ah yes i wouldn't have gotten this far without your comment there, so thanks for that @armanbilge!

ahjohannessen · 2023-06-05T19:05:48Z

I will take a look when I am at a computer 👍🏻

ahjohannessen · 2023-06-06T09:15:29Z

@mackenziestarr I will give it a try now.

@armanbilge I get an error with the message "Bug generating artifact download steps" on my machine when using sbt-typelevel 0.4.21 <= :/

ahjohannessen · 2023-06-06T09:38:17Z

@mackenziestarr I can see that you assigned crossScalaVersions := Nil - However that generates an empty scala collection in ci.yml - I tried to remove it, but that results in only Scala3 being is used for testing / build.

mackenziestarr · 2023-06-06T13:45:30Z

hey @ahjohannessen thanks for trying out the patch, I saw @armanbilge linked one of their sbt-projectmatrix builds in discord

https://discord.com/channels/632277896739946517/940325169057107968/1103716618363740200

using that as inspiration I added githubWorkflowBuildSbtStepPreamble := Seq(), to inThisBuild and removed setting crossScalaVersions to Nil. Attached the build.sbt diff and resulting diff of running sbt githubWorkflowGenerate below

https://gist.github.com/mackenziestarr/768bad44e7a814cb9172fa9ae7dd4cdc

curious if this would work since it still seems to be producing the right artifacts with sbt tlReleaseLocal (though curiously with the diff above about I get two snapshots per invocation of sbt tlReleaseLocal 🤔)

for i in 2.12 2.13 3; do (artifact=~/.ivy2/local/org.typelevel/fs2-grpc-runtime_$i/**/jars/fs2-grpc-runtime_$i.jar; echo $artifact; grep '.tasty' $artifact); done 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.12/2.5.11-8-5e2ae15-20230606T133959Z-SNAPSHOT/jars/fs2-grpc-runtime_2.12.jar 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.12/2.5.11-8-5e2ae15-20230606T134009Z-SNAPSHOT/jars/fs2-grpc-runtime_2.12.jar
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.11-8-5e2ae15-20230606T134006Z-SNAPSHOT/jars/fs2-grpc-runtime_2.13.jar 
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_2.13/2.5.11-8-5e2ae15-20230606T134009Z-SNAPSHOT/jars/fs2-grpc-runtime_2.13.jar
/home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.11-8-5e2ae15-20230606T134009Z-SNAPSHOT/jars/fs2-grpc-runtime_3.jar
grep: /home/mstarr/.ivy2/local/org.typelevel/fs2-grpc-runtime_3/2.5.11-8-5e2ae15-20230606T134009Z-SNAPSHOT/jars/fs2-grpc-runtime_3.jar: binary file matches

armanbilge · 2023-06-06T13:58:24Z

Ahh, thanks for digging that up! Yes, that's exactly what I suggest to do in this case, it should work.

ahjohannessen · 2023-06-06T15:19:00Z

@mackenziestarr This PR is green. I had to add

    scalacOptions := {
      if (tlIsScala3.value) { scalacOptions.value.filterNot(_ == "-Ykind-projector:underscores") }
      else scalacOptions.value
    }

because otherwise it results in an error about repeated kind-projector.

mackenziestarr · 2023-06-06T15:22:20Z

@ahjohannessen hooray 🙌 I saw that warning as well, thanks for adding

ahjohannessen · 2023-06-06T15:26:13Z

@mackenziestarr I published v2.7.1 - Let's see how goes :)

ahjohannessen · 2023-06-06T15:55:17Z

Seems like 2.7.1 produces proper fs2-grpc-runtime_2.13-2.7.1.jar now, can you verify @mackenziestarr

mackenziestarr · 2023-06-06T16:15:23Z

@ahjohannessen pulled in the dep and it looks great, thanks so much for working with me on this and a big thanks to @armanbilge for blazing the trail

armanbilge · 2023-06-06T16:16:05Z

Very nice work, thanks everyone!!

armanbilge closed this as completed Jun 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Since v2.5.0 `fs2-grpc-runtime_2.13-2.5.0.jar` is actually a Scala 3 artifact ... #620

Since v2.5.0 `fs2-grpc-runtime_2.13-2.5.0.jar` is actually a Scala 3 artifact ... #620

armanbilge commented May 10, 2023 •

edited

Loading

ahjohannessen commented May 11, 2023

mackenziestarr commented May 11, 2023

ahjohannessen commented May 12, 2023 •

edited

Loading

armanbilge commented May 12, 2023

ahjohannessen commented May 13, 2023

ahjohannessen commented May 16, 2023

mackenziestarr commented Jun 2, 2023

ahjohannessen commented Jun 2, 2023

mackenziestarr commented Jun 5, 2023 •

edited

Loading

armanbilge commented Jun 5, 2023

mackenziestarr commented Jun 5, 2023

ahjohannessen commented Jun 5, 2023

ahjohannessen commented Jun 6, 2023

ahjohannessen commented Jun 6, 2023

mackenziestarr commented Jun 6, 2023 •

edited

Loading

armanbilge commented Jun 6, 2023

ahjohannessen commented Jun 6, 2023

mackenziestarr commented Jun 6, 2023

ahjohannessen commented Jun 6, 2023

ahjohannessen commented Jun 6, 2023

mackenziestarr commented Jun 6, 2023

armanbilge commented Jun 6, 2023

Since v2.5.0 fs2-grpc-runtime_2.13-2.5.0.jar is actually a Scala 3 artifact ... #620

Since v2.5.0 fs2-grpc-runtime_2.13-2.5.0.jar is actually a Scala 3 artifact ... #620

Comments

armanbilge commented May 10, 2023 • edited Loading

ahjohannessen commented May 11, 2023

mackenziestarr commented May 11, 2023

ahjohannessen commented May 12, 2023 • edited Loading

armanbilge commented May 12, 2023

ahjohannessen commented May 13, 2023

ahjohannessen commented May 16, 2023

mackenziestarr commented Jun 2, 2023

ahjohannessen commented Jun 2, 2023

mackenziestarr commented Jun 5, 2023 • edited Loading

armanbilge commented Jun 5, 2023

mackenziestarr commented Jun 5, 2023

ahjohannessen commented Jun 5, 2023

ahjohannessen commented Jun 6, 2023

ahjohannessen commented Jun 6, 2023

mackenziestarr commented Jun 6, 2023 • edited Loading

armanbilge commented Jun 6, 2023

ahjohannessen commented Jun 6, 2023

mackenziestarr commented Jun 6, 2023

ahjohannessen commented Jun 6, 2023

ahjohannessen commented Jun 6, 2023

mackenziestarr commented Jun 6, 2023

armanbilge commented Jun 6, 2023

Since v2.5.0 `fs2-grpc-runtime_2.13-2.5.0.jar` is actually a Scala 3 artifact ... #620

Since v2.5.0 `fs2-grpc-runtime_2.13-2.5.0.jar` is actually a Scala 3 artifact ... #620

armanbilge commented May 10, 2023 •

edited

Loading

ahjohannessen commented May 12, 2023 •

edited

Loading

mackenziestarr commented Jun 5, 2023 •

edited

Loading

mackenziestarr commented Jun 6, 2023 •

edited

Loading