Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using pysha3 #2599

Open
0-wiz-0 opened this issue Nov 14, 2022 · 2 comments
Open

Stop using pysha3 #2599

0-wiz-0 opened this issue Nov 14, 2022 · 2 comments
Labels

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Nov 14, 2022

According to its github README, pysha3 was only ever for python versions before 3.6 and after that, the hashlib module should be used. Please do that :)

To quote https://github.com/tiran/pysha3:

The pysha3 package has reached its end of life and is no longer supported.

The SHA-3 code was merged into Python 3.6 many years ago. Please use SHA-3 functions from [hashlib](https://docs.python.org/3/library/hashlib.html) module directly.
@0-wiz-0 0-wiz-0 added the idea label Nov 14, 2022
@elopez
Copy link
Member

elopez commented Nov 14, 2022

Thanks for the report! Indeed, we're looking to migrate away from pysha3 across several of our tools. The hashlib module does not offer keccak256 hashes (which pysha3 did) so we're moving to pycryptodome instead.

Related: crytic/crytic-compile#309, crytic/solc-select#128, crytic/slither#1454

@0-wiz-0
Copy link
Author

0-wiz-0 commented Nov 14, 2022

Looks like you're well on your way already, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants