proto3 doesn't pack repeated fields by default

[daniel-sherwood]

The code here

prost/prost-build/src/code_generator.rs

Line 435 in 63c0024

.map_or(self.syntax == Syntax::Proto3, |options| options.packed())

attempts to set the default behaviour for proto3 to be packed, however because options.packed() returns false unless [packed = true] is set on the field, this fails.

[daniel-sherwood]

Just realised this is only the case where the field has other attributes and hence options is not None

[caspermeijn]

I don't understand what your request is. Can you describe your observed behavior and your expected behavior? An example file or project will help with reproducing your problem.

[bhollis]

We're hitting the same bug. Consider a field like this:

  repeated uint64 user_ids = 2 [
    (buf.validate.field).repeated.min_items = 1,
    (buf.validate.field).repeated.max_items = 25
  ];

This generates the following from prost:

#[prost(uint64, repeated, packed="false", tag="2")]
pub user_ids: ::prost::alloc::vec::Vec<u64>,

However if I remove the options, like this:

  repeated uint64 user_ids = 2;

Then the generated code looks like this:

#[prost(uint64, repeated, tag="2")]
pub user_ids: ::prost::alloc::vec::Vec<u64>,

As @daniel-sherwood correctly identified, this is a bug at

prost/prost-build/src/code_generator.rs

Lines 431 to 438 in 63c0024

	if can_pack(&field)
	&& !field
	.options
	.as_ref()
	.map_or(self.syntax == Syntax::Proto3, |options| options.packed())
	{
	self.buf.push_str(", packed=\"false\"");
	}

In my first example, there are options on the field so map_or does not use its default and the code falls back to options.packed(). options.packed() appears to be either true or false, with a default of false. But it should default to true if the file is in proto3 syntax.

[caspermeijn]

Thanks, now I understand your problem better. Are you willing to open a PR to fix this?

[bhollis]

Maybe! It'd be my first time trying Rust, so it'd probably take a while.