Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color pattern adding is broken in v2.2.9 #183

Open
todbot opened this issue Nov 14, 2022 · 0 comments
Open

Color pattern adding is broken in v2.2.9 #183

todbot opened this issue Nov 14, 2022 · 0 comments

Comments

@todbot
Copy link
Owner

todbot commented Nov 14, 2022

A regression happened in saving patterns, as reported here todbot/blink1#669

This should add a color pattern:

curl 'http://localhost:8934/blink1/pattern/add?pname=blink4green&pattern=4,%2300ff00,1.5,%23000000,0.5'

with the JSON response being:

{
  "pattern": {
    "name": "blink4green",
    "id": "blink4green",
    "pattern": "4,#00ff00,1.5,0,0.5,0.1,0"
  },
  "status": "pattern add: pattern 'blink4green' added"
}

And the pattern is visible in curl 'http://localhost:8934/blink1/patterns'

But in v2.2.9, the JSON response to /blink1/pattern/add is:

{
  "pattern": null,
  "status": "pattern add: pattern 'blink3_red' added"
}

This is clearly a bug. Verified in v2.2.9 but works in v2.2.8.

@todbot todbot closed this as completed in 26ee48d Nov 15, 2022
@todbot todbot reopened this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant