Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pie Chart Colour Schema Not Accurate #119

Open
ChintzRuparel opened this issue Aug 16, 2022 · 6 comments
Open

Pie Chart Colour Schema Not Accurate #119

ChintzRuparel opened this issue Aug 16, 2022 · 6 comments

Comments

@ChintzRuparel
Copy link

Hello,

Great Work on this repository.
Just had one small issue regarding the colour schema.
As you can see from the above example, The colour between Javascript and Python look very similar. Hence sparking some confusion. Jus some sort of other colour can be used for differentiation.

Thanks,
ChintzRuparel

Screenshot 2022-08-16 at 10 03 50
@ChintzRuparel
Copy link
Author

Hey @iProdigy,

Do lemme know any fixes or explanation for this.

Regards and Thanks,
@ChintzRuparel

@iProdigy
Copy link
Contributor

iProdigy commented Oct 8, 2022

The explanation is the visualization currently only uses these few colors & the github language colors don't fit into a nice palette (i've tried before)

@ChintzRuparel
Copy link
Author

Oh @iProdigy !
Maybe I'll create a build with different colour schema and create a pull request for the same!
Do lemme know if it works by!

@ChintzRuparel
Copy link
Author

The number of less colours added in this pie chart is maybe the problem.
The colours are itself repeating once all colours on the Colour Array are finished.
So once all 6 colours are used it will again loop back to the first one!

ChintzRuparel added a commit to ChintzRuparel/profile-summary-for-github that referenced this issue Oct 10, 2022
@ChintzRuparel
Referring to Issue tipsy#119
6a48d74 
The colour schema on the pie chart isn't that accurate in nature. 
Hence a new colour schema has been provided.

The issue with the old colour schema was that beyond a certain number of values the thing got looped and the same colours were used over and over again. Hence making a colour schema which is accurate was of utmost importance and making this thing usable to everyone in a very simpler way. 

Note to devs - Do lemme know what do think about it
@ChintzRuparel
Copy link
Author

Hey @iProdigy,

Just created a proposed change to this repository. Do lemme know what you think abt it.

Cheers,
@ChintzRuparel

@ChintzRuparel
Copy link
Author

Hey @iProdigy,

Please refer pull request #123

Cheers,
@ChintzRuparel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iProdigy @ChintzRuparel