Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive design/display issues and overall layout of Loadout in tarkov.dev/players/* page #1000

Open
Applefrittr opened this issue Oct 25, 2024 · 2 comments · May be fixed by #1002
Open

Comments

@Applefrittr
Copy link

Been using the player search tool recently and while it does add another dimension to everything else that's provided by tarkov.dev, I've noticed the Loadout section of a unique tarkov.dev/players/* page is a little jarring to look at, especially on smaller screens.

There seems to be no uniformity between the image sizes, the containers grow depending on sibling elements (creating alot of negative space in the containers), as well as horizontal scrolling not functioning at all (other sections on the page such as Raid Stats, Achievements, Skills, etc. shrink to fit on the screen and overflow is viewable via side scrolling ). The overflow from the Loadout section causes ALOT of dead space on the right side of the page...

image3
image4

It gets especially bad with a full loadout...

image1
image2

And then just a overall UX gripe. What am I looking at here? No labels for equipment slots, just a bunch of div elements...

image0

And that's not to mention certain slots can be clicked to show items contained within, via dropbox. Clicking on the primary weapon for example will show all associated weapon attachments, which in turn may contain MORE dropboxes depending on which attachment is clicked, shifting the content further down the page and exacerbating the issues I mentioned in paragraph two.

Would love to see an overhaul of this particular element so it conforms to the rest of the page and is somewhat pleasing to look at. Willing to take a crack at it as well. Obviously my ideas for changes are subjective so can post some progress here to see if the changes are looking good.

Thanks!

@Shebuka
Copy link
Contributor

Shebuka commented Oct 25, 2024

As you can see no one of us is a good responsive designer, specifically when it comes to tables 😅

If you can contribute with a solution it will be awesome! 🎉

@Applefrittr
Copy link
Author

Took a look at the source code and it looks like there are several components interacting with each other to display item images. Isolating a solution might be the best option as I don't want any changes to existing components to inadvertently break something else on the site. I'll chip away at it during my free time 😃

Applefrittr added a commit to Applefrittr/tarkov-dev that referenced this issue Oct 27, 2024
Razzmatazzz added a commit that referenced this issue Oct 28, 2024
Issue #1000 Responsive design changes and element overhaul to Player Loadout in tarkov.dev/players/* pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants