Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do runtime check to ensure update validator has the same parameter signature as update it validates #2317

Closed
Quinn-With-Two-Ns opened this issue Nov 14, 2024 · 0 comments · Fixed by #2323
Closed

Do runtime check to ensure update validator has the same parameter signature as update it validates #2317

Quinn-With-Two-Ns opened this issue Nov 14, 2024 · 0 comments · Fixed by #2323
Labels
enhancement User experience

Comments

@Quinn-With-Two-Ns
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We need to make sure at runtime the parameter portion of the signature of the validator matches the parameter portion of the signature of the update method it is validating.

Additional context
temporalio/sdk-python#689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement User experience
Projects
None yet
Milestone
No milestone
1 participant
@Quinn-With-Two-Ns