Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CRLF #67

Open
bakkot opened this issue May 3, 2020 · 3 comments
Open

Handle CRLF #67

bakkot opened this issue May 3, 2020 · 3 comments

Comments

@bakkot
Copy link
Contributor

bakkot commented May 3, 2020

We should handle Windows line endings somehow, either by explicitly supporting them in input (though presumably outputting them as just '\n') or (my preference) explicitly disallowing them, with a useful error message.
@bakkot bakkot mentioned this issue May 3, 2020
Merged
@michaelficarra
Copy link
Member

What's the error message currently? Something like "Unexpected \r"?

@bakkot
Copy link
Contributor Author

bakkot commented May 4, 2020

No, it's parsed as text.

@michaelficarra
Copy link
Member

Oh god, yeah rejecting it with a nice error sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelficarra @bakkot