page.data mutable in legacy mode

[henrykrinkle01]

Describe the bug

I found that the new page.data is mutable in legacy mode but not in rune mode.

Reproduction

Can't import from the new '$app/state` module in Sveltelab for unknown reasons (Kit updated). So here is the code:

//+page.server.ts
export async function load() {
    return { random: Math.random() }
}

<script lang="ts">
	import { page } from '$app/state';
</script>

{page.data.random}
<button onclick={() => page.data.random++}> Increment </button>

Logs

No response

System Info

N/A

Severity

annoyance

Additional Information

No response

[eltigerchino]

If anything, page.data should be immutable in both modes with clearer warnings. Although, that conflicts with how it currently works with the page store...

SvelteKit makes three readonly state objects available via the $app/state module — page, navigating and updated.

• https://svelte.dev/docs/kit/$app-state

[dummdidumm]

This isn't related to the page state specifically, it's related to how Svelte 4 (and therefore legacy mode) behaves when imports are mutated.

In this playground example, you can see that when clicking the button, incrementing the value causes reactivity: The $: statement reruns, and the attribute is updated - only the text is not updated for some reason.

So while we could adjust Svelte 5 to not update the text when mutations to an import happen, we cannot and should not adjust the behavior here, as this has nothing to do with $app/state specifically.

Re immutability warnings: I'm not sure what we can really do here without wrapping it in a proxy, and that will cause problems itself. I think it's fine as is.

[henrykrinkle01]

Why can't page.data be mutable by default?
We found a way to make it mutable anyway

[dummdidumm]

Because it's a recipe for chaos - better to have it be a reflection of what your actual data is and change it through specific actions

[henrykrinkle01]

I just wanted something like a mutable data prop, which is currently immutable. Questions related to this problem pop up almost everyday in the Discord server. Therefore the first thing I tested when the PR came out was whether page.data is mutable. I was kinda surprised that it is but later found out that it isn't in rune mode.
Do you have any update on PR #11809?