Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating MediaQuery in favor of Svelte's implementation #173

Closed
xiBread opened this issue Dec 8, 2024 · 0 comments
Closed
Labels
documentation Improvements or additions to documentation

Comments

@xiBread
Copy link

xiBread commented Dec 8, 2024

Change Type

Removal

Proposed Changes

Considering that Svelte now has its own reactive MediaQuery class built in, I'm not sure if it's necessary maintaining a userland implementation other than for backwards compat.

The only thing missing is the ability to pass in a function, but in my opinion, I don't think this is really a dealbreaker.

https://svelte.dev/docs/svelte/svelte-reactivity#MediaQuery

@xiBread xiBread added the documentation Improvements or additions to documentation label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants