Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript type definition missing Annotation.on #59

Open
msakrejda opened this issue Oct 2, 2019 · 1 comment · May be fixed by #67
Open

TypeScript type definition missing Annotation.on #59

msakrejda opened this issue Oct 2, 2019 · 1 comment · May be fixed by #67

Comments

@msakrejda
Copy link

It looks like this function

d3-annotation/src/Adapter-d3.js

Line 259 in d43a6a2

annotation.on = function() {
is not present in the type definition. Is this just an omission?
@susielu
Copy link
Owner

susielu commented Oct 28, 2019

Hmm I'm not sure @samccone can you help me look at this?

nobitagit added a commit to nobitagit/d3-annotation that referenced this issue Oct 30, 2019
@nobitagit
TS typedefs: annotate annotation.on
498243f 
Fixes susielu#59
@nobitagit nobitagit linked a pull request Oct 30, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/59 - TS typedef nobitagit/d3-annotation
2 participants
@msakrejda @susielu