Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddpg.keras-rl.py actual directory #197

Open
ghost opened this issue Aug 16, 2019 · 3 comments
Open

ddpg.keras-rl.py actual directory #197

ghost opened this issue Aug 16, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 16, 2019

This could possibly be just a noob mistake for not discovering it easily, but the information in the Training Your First Models page could be quite confusing for some.

In particular, with respect to the latest osim-rl package, the ddpg.keras-rl.py script is actually located in the osim-rl/examples/under-construction directory rather than the osim-rl/example directory.

Hence the cd osim-rl/examples command in the respective page needs to be updated to cd osim-rl/examples/under-construction in order to run the following commands.

@smsong
Copy link
Collaborator

smsong commented Aug 16, 2019

@fairread Yes, you are right. That page is out of date. Please refer to this page: http://osim-rl.stanford.edu/docs/nips2019/training/

@drozzy
Copy link

drozzy commented Aug 17, 2019

But that doesn't work either... @smsong
Following that http://osim-rl.stanford.edu/docs/nips2019/training/ page, when I execute the:

python -m examples.train_arm --train --model sample

I get this error:

ModuleNotFoundError: No module named 'rl'

@kidzik
Copy link
Member

kidzik commented Aug 19, 2019

It requires keras-rl, I'll update the doc, thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants