-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make properties vault.addr and vault.uri equivalent #592
Comments
From Vault-only perspective, it's a neat feature but that easily opens a can of worms as there are a lot of other properties (VAULT_TOKEN, SKIP_VERIFY, ...) that could be supported. From a Spring perspective, it's common to have well-defined properties and a tool like Spring Vault has a single preferred approach to configuration. A more sophisticated approach features Spring Boot with property source ordering and config property normalization. Can you tell us a bit of background where this proposal stems from so we can learn about the use-case? |
Thanks, Mark. If I am a Vault (human) operator, I want to put a common set of Vault environment variables into a client process environment and have those processes honor those standard names. No matter if the client is Java, Go, bash, or the Vault native reference client, I figured I could do no better at naming than the Vault docs themselves do. So it would be a nice creature comfort if all client species could honor the names Vault itself chooses for core Vault config. Having to configure Spring clients with My Spring is pretty rusty, so there may be a way I can elegantly affect the translation under the covers so my users don't have to know much about what I consider canonical names. But I'd rather not have to do that. I also realize there are other VAULT_ -like properties Spring defines that Vault does not, which I (guess) think is fine(?). Hope this helps clarify where I'm coming from (and realizing it may possibly not). |
Thanks a lot for the insight. From that perspective, it would make sense to investigate which Vault-supported environment variables apply also to Spring Vault and try to use these as fallback if the primary property defined by We should not try to apply property name translation from system properties to environment variables, rather use constant env variable names. Do you want to submit a pull request? |
@mp911de I have analysed the file
If there is any other convention we follow in this project please let me know , i will be happy to take this up. |
Let me know whether that helps. |
Vault defines an environment variable VAULT_ADDR to hold the Vault URL for the
vault
command line reference client. Spring Vault defines an equivalent property vault.uri in itsEnvironmentVaultConfiguration
class.Is it reasonable to enhance
EnvironmentVaultConfiguration
so that it treatsvault.uri
and a proposedvault.addr
as equivalent, givenVAULT_ADDR
is an existing well-known name in Vault operation?The text was updated successfully, but these errors were encountered: