Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathMatchingResourcePatternResolver is not able to resolve file in SpringBoot Packaged JAR #34126

Open
pawank94 opened this issue Dec 20, 2024 · 0 comments
Labels
status: waiting-for-triage An issue we've not yet triaged or decided on

Comments

@pawank94
Copy link

pawank94 commented Dec 20, 2024

This issue is happening for Spring Boot generated JAR file
When resolving for a path in JAR file jar:file:~/Documents/_GIT/xxxxx/example.jar!/BOOT-INF/classes!/com/xxxx in PathMatchingResourcePatternResolver. . The changes done in this commit seem to cause an issue.

Old Code:

for (Enumeration<JarEntry> entries = jarFile.entries(); entries.hasMoreElements(); ) {
				JarEntry entry = entries.nextElement();
				String entryPath = entry.getName();
				entryCache.add(entryPath);
				if (entryPath.startsWith(rootEntryPath)) {

New Code

for (String entryPath : jarFile.stream().map(JarEntry::getName).sorted().toList()) {
				entriesCache.add(entryPath);
				if (entryPath.startsWith(rootEntryPath)) {

Upon analyzing, I noticed jarFile.entries() produces a different file path compared to jarFile.stream().map(JarEntry::getName). For the new code, the generated entryPath has the BOOT-INFO/ prefix added to it and the following .startsWith() check fails because of that.

This creates problems in resolving a resource in the Spring-Boot generated JAR File for New Code.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Development

No branches or pull requests

2 participants