Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send partial message with #34088

Open
OPeyrusse opened this issue Dec 13, 2024 · 0 comments
Open

Cannot send partial message with #34088

OPeyrusse opened this issue Dec 13, 2024 · 0 comments
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-triage An issue we've not yet triaged or decided on

Comments

@OPeyrusse
Copy link

As we can see in the code snippet below, it is not possible to send TextMessage where isLast is set to false.

protected void sendTextMessage(TextMessage message) throws IOException {
useSession((session, callback) -> session.sendText(message.getPayload(), callback));
}

public TextMessage(CharSequence payload, boolean isLast) {
super(payload.toString(), isLast);
this.bytes = null;
}

However, the API exists in Jetty, in the form of Session#sendPartialText(String, boolean, Callable). Is there any reason for not using it?

https://github.com/jetty/jetty.project/blob/jetty-12.0.x/jetty-core/jetty-websocket/jetty-websocket-jetty-api/src/main/java/org/eclipse/jetty/websocket/api/Session.java#L99-L110

From basic testing, it seems that calling it is still not complying, but I may have made boggus changes and broken the code.

Thank you for any reply

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 13, 2024
@snicoll snicoll added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Development

No branches or pull requests

3 participants