Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect description on Release Notes 6.2 [Web Applications] #34042

Open
infoShare opened this issue Dec 6, 2024 · 3 comments
Open

Incorrect description on Release Notes 6.2 [Web Applications] #34042

infoShare opened this issue Dec 6, 2024 · 3 comments
Assignees
@rstoyanchev
Labels
status: waiting-for-triage An issue we've not yet triaged or decided on

Comments

@infoShare
Copy link

Below release notes description is describing incorrectly current behavior.
https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-6.2-Release-Notes#web-applications

Instead of assertion, missing trailing slash is added.
#33815
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 6, 2024
@bclozel
Copy link
Member

bclozel commented Dec 6, 2024

I think our release notes are correct. Have you seen this? #33712

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Dec 6, 2024
@infoShare
Copy link
Author

#33815 was implemented after #33712

And it changed
ResourceHandlerUtils.assertLocationPath(location);
to
location = ResourceHandlerUtils.initLocationPath(location);
on
59ec871#diff-917031cb7ed2ed99024dc5ceb3b17eca25c39fd5ebd02915ab3f1e25bd0d09a4

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 6, 2024
@bclozel bclozel removed the status: feedback-provided Feedback has been provided label Dec 6, 2024
@bclozel
Copy link
Member

bclozel commented Dec 6, 2024

I think you're right. I'll defer to Rossen so that he can update this section with his perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bclozel @rstoyanchev @spring-projects-issues @infoShare