Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray no longer shows the actual executed query, instead shows the query with pdo placeholders #352

Open
pablosebastianr opened this issue Jun 13, 2024 · 4 comments
Assignees

Comments

@pablosebastianr
Copy link

Rehashing the #311 that was closed automatically.

Describe the bug
Ray was showing the actual query exectuded in the database

Versions
Ray version (you can see this in "About Ray"): 2.6.5.0 and later

You can use composer show to get the version numbers of:

  • spatie/ray package version: 1.37.2
  • spatie/laravel-ray package version (if applicable): 1.32.6

PHP version: 8.1
Laravel version: 9.52.15

To Reproduce
Steps to reproduce the behavior:

  1. Execute any query with eloquent or query builder using a parameter for a where clause

Expected behavior
Ray should show the query executed with all the bindings properly replaced, one could copy and paste that query directly into TablePlus and execute. That is no longer possible
Now it shows the placeholders of the pdo query. To make things worse it doesn't even include the bindings

Desktop (please complete the following information):

  • OS: Windows 10 Pro
  • Version: 22H2

This is the PR that broke it: https://github.com/spatie/laravel-ray/pull/306/files . That was releasead with laravel-ray 1.32.6

This is what I get using Laravel 9, laravel-ray 1.33 and Ray 2.6.9.0 (and all the ones that came after that one):

alt text

Downgrading both laravel-ray to 1.32.5 and Ray 2.6.4.0 makes it okay

alt text

I don't fully understand all what is going on there but that method is using a function specific to Laravel 10 to replace bindings.
If such function doesn't exists, returns the raw sql with the placeholders, so it makes sense that Ray shows exactly that

Ray with Laravel 10 is fine.

@pablosebastianr
Copy link
Author

Anyone ? No one ?

@patinthehat
Copy link
Contributor

@pablosebastianr Thanks for re-reporting the issue, and for doing some digging on the root cause. As time permits, I'll see if I can PR this, or we'd be happy to review a PR if you'd like to tackle it 👍

@spatie-bot
Copy link

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.

@pablosebastianr
Copy link
Author

This is brilliant. Now two solved tickets without doing anything at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants