Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using set-output in GitHub Actions #2399

Open
wants to merge 9 commits into
base: 2.x
Choose a base branch
from
Open

Avoid using set-output in GitHub Actions #2399

wants to merge 9 commits into from

Conversation

zorgiepoo
Copy link
Member

Fixes #2354

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Testing this in CI and seeing if an analyzer warning gets triggered.

@zorgiepoo zorgiepoo added this to the 2.5 milestone Jul 2, 2023
@Sparkle-Bot
Copy link
Contributor

@Sparkle-Bot
Copy link
Contributor 

        NSMutableArray *arguments = [@[@"attach", _archivePath, @"-mountpoint", mountPoint, /*@"-noverify",*/ @"-nobrowse", @"-noautoopen"] mutableCopy];
                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
note: Building targets in dependency order
note: Target dependency graph (9 targets)
    Target 'Sparkle' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleDownloader' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerConnection' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerLauncher' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerStatus' in project 'Sparkle'
        ➜ Explicit dependency on target 'Autoupdate' in project 'Sparkle'
        ➜ Explicit dependency on target 'Installer Progress' in project 'Sparkle'
    Target 'Installer Progress' in project 'Sparkle' (no dependencies)
    Target 'Autoupdate' in project 'Sparkle'
        ➜ Explicit dependency on target 'bsdiff' in project 'Sparkle'
        ➜ Explicit dependency on target 'ed25519' in project 'Sparkle'
    Target 'ed25519' in project 'Sparkle' (no dependencies)
    Target 'bsdiff' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerStatus' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerLauncher' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerConnection' in project 'Sparkle' (no dependencies)
    Target 'SparkleDownloader' in project 'Sparkle' (no dependencies)
note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') ```

@Sparkle-Bot
Copy link
Contributor

$(cat anaylze_output.txt)

@Sparkle-Bot
Copy link
Contributor 

        NSMutableArray *arguments =   [@[@"attach", _archivePath, @"-mountpoint", mountPoint, /*@"-noverify",*/ @"-nobrowse", @"-noautoopen"] mutableCopy];
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
note: Building targets in dependency order
note: Target dependency graph (9 targets)
    Target 'Sparkle' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleDownloader' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerConnection' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerLauncher' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerStatus' in project 'Sparkle'
        ➜ Explicit dependency on target 'Autoupdate' in project 'Sparkle'
        ➜ Explicit dependency on target 'Installer Progress' in project 'Sparkle'
    Target 'Installer Progress' in project 'Sparkle' (no dependencies)
    Target 'Autoupdate' in project 'Sparkle'
        ➜ Explicit dependency on target 'bsdiff' in project 'Sparkle'
        ➜ Explicit dependency on target 'ed25519' in project 'Sparkle'
    Target 'ed25519' in project 'Sparkle' (no dependencies)
    Target 'bsdiff' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerStatus' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerLauncher' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerConnection' in project 'Sparkle' (no dependencies)
    Target 'SparkleDownloader' in project 'Sparkle' (no dependencies)
note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') ```

@Sparkle-Bot
Copy link
Contributor

/Users/runner/work/Sparkle/Sparkle/Autoupdate/SUDiskImageUnarchiver.m:83:41: warning: Array element cannot be nil [osx.cocoa.NilArg] NSMutableArray *arguments = [@[@"attach", _archivePath, @"-mountpoint", mountPoint, /*@"-noverify",*/ @"-nobrowse", @"-noautoopen"] mutableCopy]; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. note: Building targets in dependency order note: Target dependency graph (9 targets) Target 'Sparkle' in project 'Sparkle' ➜ Explicit dependency on target 'SparkleDownloader' in project 'Sparkle' ➜ Explicit dependency on target 'SparkleInstallerConnection' in project 'Sparkle' ➜ Explicit dependency on target 'SparkleInstallerLauncher' in project 'Sparkle' ➜ Explicit dependency on target 'SparkleInstallerStatus' in project 'Sparkle' ➜ Explicit dependency on target 'Autoupdate' in project 'Sparkle' ➜ Explicit dependency on target 'Installer Progress' in project 'Sparkle' Target 'Installer Progress' in project 'Sparkle' (no dependencies) Target 'Autoupdate' in project 'Sparkle' ➜ Explicit dependency on target 'bsdiff' in project 'Sparkle' ➜ Explicit dependency on target 'ed25519' in project 'Sparkle' Target 'ed25519' in project 'Sparkle' (no dependencies) Target 'bsdiff' in project 'Sparkle' (no dependencies) Target 'SparkleInstallerStatus' in project 'Sparkle' (no dependencies) Target 'SparkleInstallerLauncher' in project 'Sparkle' (no dependencies) Target 'SparkleInstallerConnection' in project 'Sparkle' (no dependencies) Target 'SparkleDownloader' in project 'Sparkle' (no dependencies) note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')

@zorgiepoo zorgiepoo removed this from the 2.5 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use set-output in GitHub actions workflows
2 participants
@zorgiepoo @Sparkle-Bot