Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] avoid setup-golang tools when downloading a binary #3073

Open
kapilt opened this issue Jan 10, 2024 · 3 comments · May be fixed by #3074
Open

[feature] avoid setup-golang tools when downloading a binary #3073

kapilt opened this issue Jan 10, 2024 · 3 comments · May be fixed by #3074
Labels
area:generate-builder Issue related to the generate-builder action type:feature New feature or request
Milestone
Next release

Comments

@kapilt
Copy link

kapilt commented Jan 10, 2024

Is your feature request related to a problem? Please describe.

I'm currently getting warnings from setup-golang action, due to having already setup golang with a different version and cache location.

That slsa generator needs it when its downloading a binary seems erroneous and is a causing this spurious message as well as wasting ci time.

https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/generate-builder/action.yml

instead the setup-golang step should be conditional on the input if the tool is to be built.

Screenshot 2024-01-10 at 6 12 44 AM
@kapilt kapilt added status:triage Issue that has not been triaged type:feature New feature or request labels Jan 10, 2024
@kapilt
Copy link
Author

kapilt commented Jan 10, 2024 •
edited
Loading

I'll note the warning here would also be addressed by #2864

@kapilt kapilt linked a pull request Jan 10, 2024 that will close this issue
Open
@laurentsimon laurentsimon added this to the Next release milestone Jan 16, 2024
@ianlewis
Copy link
Member

That slsa generator needs it when its downloading a binary seems erroneous and is a causing this spurious message as well as wasting ci time.

If downloading the binary this is true but the Go compiler will be needed when building from source. We could add a conditional to only run setup-go when the compiler is needed (which is most often for our pre-submits etc. anyway).

@ianlewis
Copy link
Member

@kapilt
Also, just curious, how are you running into this issue? Our workflows should be calling generate-builder as part of reusable workflows which are run in their own VM. are you calling generate-builder directly yourself?

@ianlewis ianlewis added area:generate-builder Issue related to the generate-builder action and removed status:triage Issue that has not been triaged labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:generate-builder Issue related to the generate-builder action type:feature New feature or request
Projects
None yet
Milestone
Next release
Development

Successfully merging a pull request may close this issue.

fix: don't setup-golang when downloading a binary kapilt/slsa-github-generator
3 participants
@kapilt @ianlewis @laurentsimon