-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching option does not work #45
Comments
Does it work directly with webpack? |
No idea, documentation does not say much. |
You should probably make sure that is working first. Since this plugin doesn't do any caching, just interfaces with webpack itself, it's likely not an issue here. For general questions on how webpack works, try their https://gitter.im/webpack/webpack channel or stackoverflow. If you figure it out please add it to webpack's docs, they are freely editable. |
This is actually an issue with the plugin, as it is creating a new instance of webpack on every run, as far as I can tell. |
@shama — const compiler = webpack(webpackConfig)
...
.pipe(webpackStream(compiler, cb)) For caching to work, we have to use the same instance on subsequent compiles. Update I've made a PR, #109, that fixes this by caching webpack internally. No API change was necessary. |
It seems that setting cache to true has no impact on webpack's gulp plugin.
The text was updated successfully, but these errors were encountered: