Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official support for LG WebOS TV #1330

Open
kingctan opened this issue Mar 2, 2018 · 58 comments
Open

Official support for LG WebOS TV #1330

kingctan opened this issue Mar 2, 2018 · 58 comments
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this platform: WebOS Issues affecting WebOS priority: P4 Nice to have / wishful thinking type: CI An issue with our continuous integration tests type: enhancement New feature or request
Milestone

Comments

@kingctan
Copy link

kingctan commented Mar 2, 2018

Does this player support LG WebOS TV for DASH&playready combination?
Thanks.

@chrisfillmore
Copy link
Contributor

I don't think that Shaka team has investigated this platform specifically. Generally speaking, Shaka supports any platform that is spec-compliant, but in my experience these kinds of smart TV platforms are not very mature and require extensive testing, validation, and workarounds. Things are getting better, though.

We will soon be investigating LG WebOS for DASH-PR, so you may soon see tickets related to this platform, and you'll get a better sense for whether or not Shaka will work on these TV's.

@joeyparrish
Copy link
Member

We have never tested Shaka Player on this platform, but you can help by running our support page and sending a screenshot: https://shaka-player-demo.appspot.com/support.html

This will tell us whether or not the platform has the basic capabilities we need, and if so, what specific containers, codecs, and DRM systems it has.

@joeyparrish joeyparrish added the type: question A question from the community label Mar 2, 2018
@avelad
Copy link
Member

avelad commented Mar 2, 2018

We are using ShakaPlayer with WebOS 3.5 and DASH+Widevine without any problem.

@ismena ismena added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 19, 2018
@ismena
Copy link
Contributor

ismena commented Mar 19, 2018

@kingctan Does this answer your question? Is there anything else we can do?

@chrisfillmore
Copy link
Contributor

@ismena I have a question. It seems there are at least 3 projects using Shaka on LG WebOS: @kingctan, @avelad, and me. Would Shaka team be willing to adopt this as an officially supported platform?

@avelad
Copy link
Member

avelad commented Mar 23, 2018

@chrisfillmore , What versions of WebOS have you tried? I only tried WebOS 3.5.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 23, 2018
@ismena
Copy link
Contributor

ismena commented Mar 23, 2018

Let's get our TL to consider it!
@joeyparrish

@shaka-bot
Copy link
Collaborator

@kingctan Does this answer all your questions? Can we close the issue?

@shaka-bot shaka-bot added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 27, 2018
@joeyparrish
Copy link
Member

If you can send us some documentation on WebOS testing, we could consider adding a WebOS device to our test lab. We can't call it an officially supported platform until we are running tests on it nightly to make sure we don't break it. But in general, expanding our platform coverage is a Good Thing:tm:.

In particular, we would appreciate any tips on how to automate directing the device to an arbitrary URL. That's a key part of the testing process with Karma.

@joeyparrish joeyparrish removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 27, 2018
@shaka-bot
Copy link
Collaborator

@kingctan Does this answer all your questions? Can we close the issue?

@shaka-bot shaka-bot added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 31, 2018
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, you can ask us to reopen or have the bot reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Apr 7, 2018
@chrisfillmore
Copy link
Contributor

@shaka-bot reopen please

Here is the Shaka support page for the WebOS TV I have:

Mozilla/5.0 (Web0S; Linux/SmartTV) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.122 Safari/537.36 WebAppManager
v2.3.6

{
  "manifest": {
    "application/dash+xml": true,
    "application/x-mpegurl": true,
    "application/vnd.apple.mpegurl": true,
    "application/x-offline-manifest": true,
    "mpd": true,
    "m3u8": true,
    "application/vnd.ms-sstr+xml": false,
    "ism": false
  },
  "media": {
    "video/mp4; codecs=\"avc1.42E01E\"": true,
    "video/mp4": true,
    "video/mp4; codecs=\"avc3.42E01E\"": true,
    "video/mp4; codecs=\"hev1.1.6.L93.90\"": true,
    "video/mp4; codecs=\"hvc1.1.6.L93.90\"": true,
    "video/mp4; codecs=\"hev1.2.4.L153.B0\"; eotf=\"smpte2084\"": true,
    "video/mp4; codecs=\"hvc1.2.4.L153.B0\"; eotf=\"smpte2084\"": true,
    "video/mp4; codecs=\"vp9\"": false,
    "video/mp4; codecs=\"vp09.00.10.08\"": false,
    "audio/mp4; codecs=\"mp4a.40.2\"": true,
    "audio/mp4": true,
    "audio/mp4; codecs=\"ac-3\"": true,
    "audio/mp4; codecs=\"ec-3\"": true,
    "audio/mp4; codecs=\"opus\"": false,
    "audio/mp4; codecs=\"flac\"": false,
    "video/webm; codecs=\"vp8\"": true,
    "video/webm": true,
    "video/webm; codecs=\"vp9\"": true,
    "video/webm; codecs=\"av1\"": false,
    "audio/webm; codecs=\"vorbis\"": false,
    "audio/webm": false,
    "audio/webm; codecs=\"opus\"": false,
    "video/mp2t; codecs=\"avc1.42E01E\"": false,
    "video/mp2t": false,
    "video/mp2t; codecs=\"avc3.42E01E\"": false,
    "video/mp2t; codecs=\"hvc1.1.6.L93.90\"": false,
    "video/mp2t; codecs=\"mp4a.40.2\"": false,
    "video/mp2t; codecs=\"ac-3\"": false,
    "video/mp2t; codecs=\"ec-3\"": false,
    "text/vtt": true,
    "application/mp4; codecs=\"wvtt\"": true,
    "application/mp4": true,
    "application/ttml+xml": true,
    "application/mp4; codecs=\"stpp\"": true
  },
  "drm": {
    "org.w3.clearkey": {
      "persistentState": false
    },
    "com.widevine.alpha": {
      "persistentState": false
    },
    "com.microsoft.playready": {
      "persistentState": false
    },
    "com.apple.fps.2_0": null,
    "com.apple.fps.1_0": null,
    "com.apple.fps": null,
    "com.adobe.primetime": null
  },
  "offline": true
}

The TV is a UJ6500. In "About This TV" it says Software Version 4.70.10, although I'm not totally clear if this is the WebOS version.

@chrisfillmore
Copy link
Contributor

Could we reopen this as an official WebOS support issue? I have an internal ticket assigned to me to ensure Shaka works out of the box on LG TV's, so I'm happy to help get this resolved.

@joeyparrish joeyparrish reopened this Apr 23, 2018
@joeyparrish joeyparrish changed the title Does this player support LG WebOS TV for DASH&playready combination? Official support for LG WebOS TV Apr 23, 2018
@joeyparrish joeyparrish added type: enhancement New feature or request and removed type: question A question from the community labels Apr 23, 2018
@shaka-bot shaka-bot added this to the Backlog milestone Apr 23, 2018
@joeyparrish
Copy link
Member

Sure thing. I've renamed the issue to reflect that.

@chrisfillmore, based on your support report, I see no reason WebOS shouldn't work. If you can confirm what version of WebOS you have, that would be helpful. @avelad reports that WebOS 3.5 works for him.

For this to be an officially supported platform, and not just a platform that happens to work, we will need to add a WebOS device to our lab environment and integrate it with our test automation. None of that work will affect the open-source library unless we need to adjust any of the tests themselves.

The open question is what version of WebOS we should try to put in our lab. Ideally, we would test on the oldest version we intend to support, which may be 3.5. @chrisfillmore, @avelad, we would be happy to have your input on this.

The other issue is that we may be limited in the WebOS version we can actually purchase. For example, when we tried to purchase a Tizen 2016 TV, we could only find 2017 models in stores. It seems that WebOS 3.5 models are still available, but I'm not sure about earlier models.

@avelad
Copy link
Member

avelad commented Apr 24, 2018

I'd prefer that Shaka Player supports WebOS 3.5 or above (WebOS 4 is scheduled for the end of year).

The only "strange" thing that i found in some WebOS TV is related to video resolution, eg:
Model: lg-24MT49S-PZ (this is a low end model) with HD ready resolution (1366x768px) is not able to reproduce streams of 1080p, so I need configure setMaxHardwareResolution with 1366x768

@joeyparrish
Copy link
Member

Cool, thanks for the feedback, @avelad!

@chrisfillmore
Copy link
Contributor

Ok here's what I've learned so far.

WebOS SDK
http://webostv.developer.lge.com/sdk/download/download-sdk/

Using WebOS CLI
http://webostv.developer.lge.com/sdk/using-webos-tv-cli/

Testing a WebOS app
http://webostv.developer.lge.com/sdk/using-webos-tv-cli/testing-web-app-cli/

WebOS Application Lifecycle
http://webostv.developer.lge.com/develop/app-developer-guide/web-app-lifecycle/

You can launch an app from the command line via something similar to:

ares-launch --device deviceName com.domain.app --params "{'url':'www.foo.com'}"

You can listen for this value in WebOS:

document.addEventListener('webOSLaunch', function (event) {
  console.log(event.detail.url); // www.foo.com
});

Does this help?

@asgvard
Copy link

asgvard commented Oct 20, 2020

Hi,
Just wanted to report some issue as well, as from what I understood this is the best place to do it.
We have been using Shaka 2.5.17 on WebOS down to 3.5 (TVs from 2016 year) and everything worked fine with Dash + Widevine. However after upgrading to Shaka 3.0.0+ it stopped working. The error we get is:

Failed to execute 'webkitAddKey' on 'HTMLMediaElement': The key system provided ('com.widevine.alpha') is not supported.

And I'm sure Widevine is supported there, it was already working before.
I have tried to find what has changed between 2.5.17 and 3.0.0 and it seems like the changes in the file /polyfills/patchedmediakeys_webkit.js are causing this, but I'm still in the process of finding out which exact change broke this. This whole polyfill was changed quite a lot between those 2 versions as it was migrated to ES6 class, so it makes it a bit hard to find the exact logic changes. If anyone has similar issues and did find a solution, or if anyone has an idea which changes in that file could have break this, please let me know :)

@joeyparrish
Copy link
Member

joeyparrish commented Oct 20, 2020

@asgvard, please let us now what you find out about that. We would be very happy to review a PR, but we don't have an LG TV of our own at this time.

@asgvard
Copy link

asgvard commented Oct 30, 2020

@joeyparrish Thank you for your reply!
We have done some investigation, however, it is a bit difficult to trace back all the changes in the initialization flow. I have compared 2 versions side by side and tried to output additional logs (from Shaka library as well as my own ones) to see which steps are different to find a clue about what could be an issue. The differences start from the player.js where it calls initForPlayback method.
In the 2.5.x version it goes into filterAllPeriods, then the next thing that is happening is onLoad_ callback where it first sets Media Keys, and only then creates the Media Key Session. I can also see that in 2.5.x version the session contains one key that has "usable" status.
In the 3.0.x version it goes into the filterManifest_ method where it already tries to create Media Key Session before the keys were set with setMediaKeys. I've also noticed that the keyStatuses has 0 size in this case. Then it tries to call generateRequest which after few "Ignoring duplicate init data" calls causing the player Error with the message that "com.widevine.alpha" is not supported (this error will be visible on the 2nd screenshot).
Here is the first comparison screenshot of the logs side by side: (left is 2.5.x, right is 3.0.x)
shaka-debug-session-keystatuses

Interesting thing though is that in the 3.0.x player goes into Error state (or at least we interpret it as an Error state since we get it in the onerror callback from the player) while on the 2.5.x version we also get this error, but inside onWebkitKeyMessage_. Somehow on 2.5.x after few messages like this it actually reports that the MediaKeySession is ready and it starts the streaming. SO these errors are kind of ignored and hidden only inside WebkitKeyMessages.
shaka-debug-widevine-error

Unfortunately it requires much deeper knowledge of the Shaka player architecture for us in order to understand where the problem originates, so I would appreciate it if you could have a look at these logs and share your thoughts (theoretically) about what do you think can cause such a different behavior?
For now the main 2 differences that we see is that working version has "usable" keys in the Key Session while non-working version doesn't have the key. And the second difference is that the "com.widevine.alpha" error is not impacting the playback in the 2.5.x version, but it is causing player to report an error in 3.0.x version.

Thank you in advance for any suggestions or guidance on where should we continue our investigation!

@kasmihmed
Copy link

I wouldn't mind helping

at

i have an lg tv and I wouldn't mind helping out.

@avelad
Copy link
Member

avelad commented Apr 19, 2021

Update from @joeyparrish : #3345 (comment)

@joeyparrish
Copy link
Member

These are the steps that must be done to add LG as an officially-supported platform:

  1. Build an LG TV backend in Generic WebDriver Server (Add support for LG WebOS generic-webdriver-server#18) so that we can automate tests and debug on the platform (can be done by anyone with the hardware and time and energy)
  2. Set up the LG TV test infrastructure in our lab (must be done by the Shaka team)
  3. Run all Shaka Player tests on LG TV and catalog test failures (can be done by anyone after part 1 is complete)
  4. Fix individual test failures, either by updating test cases or fixing Shaka bugs or working around platform bugs, as appropriate (can be done by anyone or many people in parallel after part 2 is complete)
  5. Enable nightly testing in the Shaka Player lab (must be done by the Shaka team)
  6. Update docs (can be done by anyone)

These are the same steps we went through this year to add official Xbox One support (step 1 PR, step 4 changes 1, 2, 3, and step 6 docs updates). If anyone is interested in helping us expand official support to LG WebOS, please feel free to volunteer!

@theodab theodab added priority: P3 Useful but not urgent flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P4 Nice to have / wishful thinking and removed priority: P3 Useful but not urgent labels Oct 1, 2021
@avelad avelad added platform: WebOS Issues affecting WebOS and removed platform: TV/STB Issues affecting smart TV or set-top box platforms labels Jun 13, 2022
@gperulliniroque
Copy link

Estamos usando ShakaPlayer con WebOS 3.5 y DASH+Widevine sin ningún problema.

Hola buenas noches estimado, podrias ayudarme con la configuracion del player. @avelad

@FelipeAndresLopez
Copy link

Estamos usando ShakaPlayer con WebOS 3.5 y DASH+Widevine sin ningún problema.

Hola buenas noches estimado, podrias ayudarme con la configuracion del player. @avelad

@avelad It would be great if you can help us with that configuration that you set, I will appreciate it.

@avelad
Copy link
Member

avelad commented Sep 5, 2023

Another WebOS topic: #5479

@stuartflanagan
Copy link

stuartflanagan commented Apr 29, 2024

@avelad Wanted to let you know the latest update 4.8.0 introduces error code 4032 when playing AES HLS on webOS.
4.7.x did not have this issue but did have the issue with over requesting AES license.
Is there a way around this issue?

@avelad
Copy link
Member

avelad commented Apr 29, 2024

@stuartflanagan In 4.8.0 there are the following related changes:

Anyway to fix any bug we need a test stream.

Please note that this is an unofficially supported platform, so if you want to submit a PR to fix this, we'd be happy to review it.

@stuartflanagan
Copy link

Thanks @avelad.
The issue actually occurs with any HLS stream. not just AES encrypted.
But here is a demo stream from unified that also triggers the 4032 error.
https://demo.unified-streaming.com/k8s/features/stable/video/tears-of-steel/tears-of-steel-aes.ism/.m3u8

The error occurs in thePlayer load sequence. Has there been any change to the isSupported method used?
It seems it is now returning false for webOS this is webOS3 through webOS2024

Happy to have a look at this. Can you please point me to any commits that may have impacted isSupported method?

    this.player
      .load(mediaItem.manifest, startTime)
      .then(() => {
        handlePlayerReady();
      })
      .catch(error => {
        this.error = error;
        this.dispatchEvent(new Event('error'));
      }); 

@avelad
Copy link
Member

avelad commented Apr 29, 2024

Are you using fMP4 or TS?

@stuartflanagan
Copy link

TS

@avelad
Copy link
Member

avelad commented Apr 29, 2024

The commit that may impact is: #6382

@stuartflanagan
Copy link

Thank you I will see how I go.

@stuartflanagan
Copy link

Seems to be affecting MPEGDASH and DRM as well.
Same error 4032.

@stuartflanagan
Copy link

Hi @avelad just wondering if I can get some help contributing for this issue.

I realise this ticket is probably not the place to do it as it is regarding offical support.

At present I have the shaka-player lib forked and it is building.

webOS is returning 4032 for manifest media types
HLS: https://demo.unified-streaming.com/k8s/features/stable/usp-s3-storage/tears-of-steel/tears-of-steel.ism/.m3u8
MPD: https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd

The interesting thing is when I switch to the debug player to investigate the logs playback is fine with no 4032 error code.

@rampratapyadav91
Copy link

minimumUpdatePeriod is 30 for live content which is causing delayed playback start if I am keeping rebufferinggoal as 30 and if set ignoreminbuffertime true then seeing a stall during playback, how to configure shaka for lower webos so that there is not any delayed playback start as well as any stall ?

@avelad avelad added the type: CI An issue with our continuous integration tests label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this platform: WebOS Issues affecting WebOS priority: P4 Nice to have / wishful thinking type: CI An issue with our continuous integration tests type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests