-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official support for LG WebOS TV #1330
Comments
I don't think that Shaka team has investigated this platform specifically. Generally speaking, Shaka supports any platform that is spec-compliant, but in my experience these kinds of smart TV platforms are not very mature and require extensive testing, validation, and workarounds. Things are getting better, though. We will soon be investigating LG WebOS for DASH-PR, so you may soon see tickets related to this platform, and you'll get a better sense for whether or not Shaka will work on these TV's. |
We have never tested Shaka Player on this platform, but you can help by running our support page and sending a screenshot: https://shaka-player-demo.appspot.com/support.html This will tell us whether or not the platform has the basic capabilities we need, and if so, what specific containers, codecs, and DRM systems it has. |
We are using ShakaPlayer with WebOS 3.5 and DASH+Widevine without any problem. |
@kingctan Does this answer your question? Is there anything else we can do? |
@chrisfillmore , What versions of WebOS have you tried? I only tried WebOS 3.5. |
Let's get our TL to consider it! |
@kingctan Does this answer all your questions? Can we close the issue? |
If you can send us some documentation on WebOS testing, we could consider adding a WebOS device to our test lab. We can't call it an officially supported platform until we are running tests on it nightly to make sure we don't break it. But in general, expanding our platform coverage is a Good Thing:tm:. In particular, we would appreciate any tips on how to automate directing the device to an arbitrary URL. That's a key part of the testing process with Karma. |
@kingctan Does this answer all your questions? Can we close the issue? |
Closing due to inactivity. If this is still an issue for you or if you have further questions, you can ask us to reopen or have the bot reopen it by including |
@shaka-bot reopen please Here is the Shaka support page for the WebOS TV I have:
The TV is a UJ6500. In "About This TV" it says Software Version 4.70.10, although I'm not totally clear if this is the WebOS version. |
Could we reopen this as an official WebOS support issue? I have an internal ticket assigned to me to ensure Shaka works out of the box on LG TV's, so I'm happy to help get this resolved. |
Sure thing. I've renamed the issue to reflect that. @chrisfillmore, based on your support report, I see no reason WebOS shouldn't work. If you can confirm what version of WebOS you have, that would be helpful. @avelad reports that WebOS 3.5 works for him. For this to be an officially supported platform, and not just a platform that happens to work, we will need to add a WebOS device to our lab environment and integrate it with our test automation. None of that work will affect the open-source library unless we need to adjust any of the tests themselves. The open question is what version of WebOS we should try to put in our lab. Ideally, we would test on the oldest version we intend to support, which may be 3.5. @chrisfillmore, @avelad, we would be happy to have your input on this. The other issue is that we may be limited in the WebOS version we can actually purchase. For example, when we tried to purchase a Tizen 2016 TV, we could only find 2017 models in stores. It seems that WebOS 3.5 models are still available, but I'm not sure about earlier models. |
I'd prefer that Shaka Player supports WebOS 3.5 or above (WebOS 4 is scheduled for the end of year). The only "strange" thing that i found in some WebOS TV is related to video resolution, eg: |
Cool, thanks for the feedback, @avelad! |
Ok here's what I've learned so far. WebOS SDK Using WebOS CLI Testing a WebOS app WebOS Application Lifecycle You can launch an app from the command line via something similar to:
You can listen for this value in WebOS:
Does this help? |
Hi,
And I'm sure Widevine is supported there, it was already working before. |
@asgvard, please let us now what you find out about that. We would be very happy to review a PR, but we don't have an LG TV of our own at this time. |
@joeyparrish Thank you for your reply! Interesting thing though is that in the 3.0.x player goes into Error state (or at least we interpret it as an Error state since we get it in the onerror callback from the player) while on the 2.5.x version we also get this error, but inside Unfortunately it requires much deeper knowledge of the Shaka player architecture for us in order to understand where the problem originates, so I would appreciate it if you could have a look at these logs and share your thoughts (theoretically) about what do you think can cause such a different behavior? Thank you in advance for any suggestions or guidance on where should we continue our investigation! |
I wouldn't mind helping
i have an lg tv and I wouldn't mind helping out. |
Update from @joeyparrish : #3345 (comment) |
These are the steps that must be done to add LG as an officially-supported platform:
These are the same steps we went through this year to add official Xbox One support (step 1 PR, step 4 changes 1, 2, 3, and step 6 docs updates). If anyone is interested in helping us expand official support to LG WebOS, please feel free to volunteer! |
Hola buenas noches estimado, podrias ayudarme con la configuracion del player. @avelad |
Another WebOS topic: #5479 |
@avelad Wanted to let you know the latest update |
@stuartflanagan In 4.8.0 there are the following related changes:
Anyway to fix any bug we need a test stream. Please note that this is an unofficially supported platform, so if you want to submit a PR to fix this, we'd be happy to review it. |
Thanks @avelad. The error occurs in thePlayer load sequence. Has there been any change to the Happy to have a look at this. Can you please point me to any commits that may have impacted
|
Are you using fMP4 or TS? |
TS |
The commit that may impact is: #6382 |
Thank you I will see how I go. |
Seems to be affecting MPEGDASH and DRM as well. |
Hi @avelad just wondering if I can get some help contributing for this issue. I realise this ticket is probably not the place to do it as it is regarding offical support. At present I have the webOS is returning 4032 for manifest media types The interesting thing is when I switch to the debug player to investigate the logs playback is fine with no 4032 error code. |
minimumUpdatePeriod is 30 for live content which is causing delayed playback start if I am keeping rebufferinggoal as 30 and if set ignoreminbuffertime true then seeing a stall during playback, how to configure shaka for lower webos so that there is not any delayed playback start as well as any stall ? |
Does this player support LG WebOS TV for DASH&playready combination?
Thanks.
The text was updated successfully, but these errors were encountered: