Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignment with ropensci statistical software standards #18

Open
2 of 3 tasks
s3alfisc opened this issue Oct 1, 2021 · 2 comments
Open
2 of 3 tasks

alignment with ropensci statistical software standards #18

s3alfisc opened this issue Oct 1, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@s3alfisc
Copy link
Owner

s3alfisc commented Oct 1, 2021

For the standards, see here: https://stats-devguide.ropensci.org/index.html

  • check with pkgcheck
  • check thatautotest::autotest() returns NULL
  • alignment with ssr package: regression standards
@s3alfisc s3alfisc added the enhancement New feature or request label Jan 17, 2022
@s3alfisc
Copy link
Owner Author

s3alfisc commented Jul 2, 2022

Fix all pkgcheck errors and warnings reported here: ropenscilabs/statistical-software-review#24.

@s3alfisc
Copy link
Owner Author

s3alfisc commented Jul 2, 2022

  • contributing file
  • add examples
  • duplicate function names
  • package coverage
  • r cmd check

All things goodpractice:

  • library() and require() calls - maybe in tests and examples (?)
  • semicolons (?)
  • replace sapply by vapply
  • enforce 80 character lines
  • rename functions pval, model_matrix
  • cyclocomplexity

Other things:

  • add check if Julia is installed, else don't run tests
  • add tests with 'hard coded' values against Julia
  • review technical vignette
  • add vignette on how to create tables with modelsummary
  • document undocumented functions

s3alfisc added a commit that referenced this issue Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant