Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGDisplayCreateUUIDFromDisplayID may be leaking? #4031

Open
madsmtm opened this issue Dec 3, 2024 · 0 comments · May be fixed by #4032
Open

CGDisplayCreateUUIDFromDisplayID may be leaking? #4031

madsmtm opened this issue Dec 3, 2024 · 0 comments · May be fixed by #4032
Labels
B - bug Dang, that shouldn't have happened DS - macos

Comments

@madsmtm
Copy link
Member

madsmtm commented Dec 3, 2024

Description

We're using CGDisplayCreateUUIDFromDisplayID, but I think that actually returns a CFUUID object that we should be releasing after use?

macOS version

ProductName:            macOS
ProductVersion:         14.7.1
BuildVersion:           23H222

Winit version

edca3eb
@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - macos labels Dec 3, 2024
killercup added a commit to killercup/winit that referenced this issue Dec 4, 2024
@killercup
Use wrapper type for CFUUID
e6e5766 
This no longer exposes `CGDisplayCreateUUIDFromDisplayID` and instead
offers a new `CfUuid` type that can be created from a display ID and
also cleans itself up on drop.

Closes rust-windowing#4031
killercup added a commit to killercup/winit that referenced this issue Dec 4, 2024
@killercup
Use wrapper type for CFUUID
b662d4e 
This no longer exposes `CGDisplayCreateUUIDFromDisplayID` and instead
offers a new `CfUuid` type that can be created from a display ID and
also cleans itself up on drop.

Closes rust-windowing#4031
@killercup killercup linked a pull request Dec 4, 2024 that will close this issue
Open
5 tasks
killercup added a commit to killercup/winit that referenced this issue Dec 4, 2024
@killercup
Use wrapper type for CFUUID
87d8a93 
This no longer exposes `CGDisplayCreateUUIDFromDisplayID` and instead
offers a new `CfUuid` type that can be created from a display ID and
also cleans itself up on drop.

Closes rust-windowing#4031
killercup added a commit to killercup/winit that referenced this issue Dec 17, 2024
@killercup
Use wrapper type for CFUUID
71b0bc2 
This no longer exposes `CGDisplayCreateUUIDFromDisplayID` and instead
offers a new `CfUuid` type that can be created from a display ID and
also cleans itself up on drop.

Closes rust-windowing#4031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B - bug Dang, that shouldn't have happened DS - macos
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use wrapper type for CFUUID killercup/winit
1 participant
@madsmtm