Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External service for approve responder isn't working #99

Open
mpadge opened this issue Aug 29, 2023 · 0 comments
Open

External service for approve responder isn't working #99

mpadge opened this issue Aug 29, 2023 · 0 comments

Comments

@mpadge
Copy link
Collaborator

mpadge commented Aug 29, 2023

We currently have our approve responder configured like this:

ropensci_approve:
only: editors
external_service:
name: badge
url: http://138.68.123.59:8000/badge
method: get
data_from_issue:
- repo
- repourl
- issue_id
template_file: approved.md
data_from_issue:
- reviewers-list
remove_labels:
- 5/awaiting-reviewer(s)-response
add_labels:
- 6/approved

The external service calls this plumber function which in turn calls roreviewapi::readme_badge(). That function should then confirm in the issue whether the repo has an rOpenSci badge in its README. That external call is, however, not made.

The external service in the welcome responder works:

welcome:
if:
value_matches:
submission-type: "Standard|Estándar|Stats"
message: "Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type `@ropensci-review-bot help` for help."
external_service:
name: editorcheck
url: http://138.68.123.59:8000/editorcheck
method: get
data_from_issue:
- repo
- repourl
- issue_id
template_file: goodpractice.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant