Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Have the approve responder fill "Version accepted" in the issue body #76

Open
maelle opened this issue Jun 14, 2022 · 3 comments
Open

Comments

@maelle
Copy link
Collaborator

maelle commented Jun 14, 2022

Issue ropensci/software-review#485
repo https://github.com/ropensci/ReLTER
the version is in the DESCRIPTION file https://github.com/ropensci/ReLTER/blob/1c85a463239be70a80608f3d9c593cfed048e627/DESCRIPTION#L4

Cc @mpadge

@maelle
Copy link
Collaborator Author

maelle commented Jun 21, 2022

I wonder whether we need a pre-approve command that will remind authors to bump their package's version. Thoughts @mpadge?

@mpadge
Copy link
Collaborator

mpadge commented Jun 21, 2022

Any body variables are automatically available for buffy, so just need buffy to grab the version from current repo (task for @xuanxu), and error if that is !>= submitted_version, otherwise proceed to fill version_accepted with that value. Right?

@maelle
Copy link
Collaborator Author

maelle commented Jun 21, 2022

oh good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants