Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasource/docker: retain os when updating #33173

Open
rarkins opened this issue Dec 17, 2024 Discussed in #33166 · 5 comments
Open

datasource/docker: retain os when updating #33173

rarkins opened this issue Dec 17, 2024 Discussed in #33166 · 5 comments
Labels
datasource:docker priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Dec 17, 2024

Discussed in #33166

Originally posted by sathieu December 17, 2024

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab ; Renovate 39.69.2

Please tell us more about your question or problem

When using an image with digest pointing to a specific architecture and os, renovate ensure the same architecture but can use another OS.

For example, this image:

registry.k8s.io/csi-vsphere/driver:v3.3.1@sha256:5ef2f153813565d41a41c0700d1917c077f30bbbe735fd3f9e9ba18956d65bed

which is os=linux architecture=amd64

Current behavior

Image is updated to:

registry.k8s.io/csi-vsphere/driver:v3.3.1@sha256:9245b0dbe11af8a90080e2d59a0e488bc6272b20d50eab3f643967c3d117a957

which is os=windows architecture=amd64

Expected behavior

Like for arcvhitecture, os should not be changed.

Logs (if relevant)

Logs
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"No registry auth required for https://registry.k8s.io/v2/csi-vsphere/driver/tags/list?n=10000","time":"2024-12-16T16:05:52.623Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getLabels(https://registry.k8s.io, csi-vsphere/driver, v3.3.1)","time":"2024-12-16T16:05:54.059Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, v3.3.1, get)","time":"2024-12-16T16:05:54.059Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, sha256:9245b0dbe11af8a90080e2d59a0e488bc6272b20d50eab3f643967c3d117a957, get)","time":"2024-12-16T16:05:54.350Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getDigest(https://registry.k8s.io, csi-vsphere/driver, v3.3.1)","time":"2024-12-16T16:05:59.652Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, sha256:5ef2f153813565d41a41c0700d1917c077f30bbbe735fd3f9e9ba18956d65bed, head)","time":"2024-12-16T16:05:59.801Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, sha256:5ef2f153813565d41a41c0700d1917c077f30bbbe735fd3f9e9ba18956d65bed, get)","time":"2024-12-16T16:06:00.984Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","registryHost":"https://registry.k8s.io","dockerRepository":"csi-vsphere/driver","msg":"Architecture-specific digest or missing docker-content-digest header - pulling full manifest","time":"2024-12-16T16:06:05.445Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, v3.3.1, get)","time":"2024-12-16T16:06:05.445Z","v":0}



https://github.com/renovate-reproductions/33166

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others datasource:docker labels Dec 17, 2024
@viceice
Copy link
Member

viceice commented Dec 17, 2024

I think this is a known limitation when the manifest list doesn't contain the required image because it's not build yet. this is a regular issue on docker hub images.

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 17, 2024

Should it self heal?

@viceice
Copy link
Member

viceice commented Dec 17, 2024

I think so

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 18, 2024

This PR is from an hour ago: https://github.com/renovate-reproductions/33166/pull/1/files

It's still windows

@sathieu
Copy link

sathieu commented Dec 18, 2024

This is not a manifest list but a manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource:docker priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

3 participants