Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finishRoute() never fired when all elementPromises don't resolve #1007

Open
davidgolden opened this issue May 17, 2019 · 0 comments
Open

finishRoute() never fired when all elementPromises don't resolve #1007

davidgolden opened this issue May 17, 2019 · 0 comments

Comments

@davidgolden
Copy link
Contributor

Inside ClientController's _render method, when all elementPromises (which are created from a page's getElements() methods) are not resolved, finishRoute() is never fired, which then breaks all page navigation because this._loading is never set to false.

This case can be created if a getElements() method returns an empty array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidgolden