Support C# Typegen +WinUI 3 Sample #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t enum variants Implements a class otherwise, always for enums. Which isn't ideal, however passing the option to the user might be wiser.
huwaireb
commented
Jul 6, 2024
|
|
||
| let config = serde_generate::CodeGeneratorConfig::new(package_name.to_string()) | ||
| .with_encodings(vec![Encoding::Bincode]) | ||
| .with_c_style_enums(true); |
There was a problem hiding this comment.
An enum like
enum Event {
Increment,
Decrement,
Reset,
}would translate to
enum Event {
Increment = 0,
Decrement = 1,
Reset = 2,
}instead of generating classes for each variant e.g Increment. Limited to enums that don't store data, those who do serde-reflection will generate a class for them.
Should we make it a parameter of the function for flexibility, or is it fine as is?
|
Yeah, this won't work. I managed to get it working twice, each different implementation both with drawbacks that are just not worth it.
I'll close this, I don't wish this on anyone. If I find a better way to do this, i'll share, for now i'm not even sure what i'll do for my own project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164
The typegen implementation primarily done,
just need to push up the requests overload.Example will be pushed tomorrow hopefully, as I clean up given it's 3 am currently 😅 and merge into simple_calculator.
Preview
Windows.11.C.Windows.App.SDK.mov