Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Replace go-based otel-cli with python one #22

Open
msarahan opened this issue Nov 13, 2024 · 2 comments
Open

Telemetry: Replace go-based otel-cli with python one #22

msarahan opened this issue Nov 13, 2024 · 2 comments
Assignees

Comments

@msarahan
Copy link
Contributor

msarahan commented Nov 13, 2024

There are 2 options for opentelemetry CLI:

The go-based one is a lot more fleshed-out. It's also much larger to download and occasionally fails with connection errors. The Python one would need some work before it would meet our needs. The attributes functionality is not connected, and it does not handle TRACEPARENT in quite the same way.

We could also look at writing a Python script using the opentelemetry python API, or even send requests with curl. At any rate, something to work on when there's time.

Closes #27
Closes #26
Closes #25

@bdice
Copy link
Contributor

bdice commented Nov 14, 2024

We should pre-install this into our CI images. We need to minimize the number of network requests during our CI execution, and having it available ahead of time would help with that.

@bdice bdice changed the title Replace go-based otel-cli with python one Telemetry: Replace go-based otel-cli with python one Nov 14, 2024
@msarahan
Copy link
Contributor Author

It's pretty awful to parse this stuff in GHA. It's just really hard to test and develop. I'm going to open a new issue to refactor the process. I think that we can use Python in the github actions (thanks to the "dispatch" idea, a .py file should be usable). By using Python, we can use the opentelemetry API/SDK libraries for Python, and that will get rid of the otel-cli download. Python will also be much more flexible for putting out information like what you request here.

There are several shortcomings with the current implementation, which does the following:

  • Download GHA run logs using GH Script
  • Parse logs using jq
  • Send opentelemetry spans using otel-cli

Other issues capture some of the shortcomings:

@msarahan msarahan self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants