You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in the docs build and test scripts when installing was a good idea to make things strict, but it seems like it is not actually safe (as noted by @jameslamb).
So, I should change it back (possibly also in one place in legate-dataframe).
A bit unclear if we need to build the .dev<N> version at all in that case, but maybe it is nice to just do it anyway.
The text was updated successfully, but these errors were encountered:
Using rapids-generate-version does not necessarily mean "including commit offsets"... for release builds (triggered by a tag matching the pattern ^v[0-9][0-9].[0-9][0-9].[0-9]$), the version number computed by that command will not have commit distance, e.g. it'd be 24.11.00, not something like 24.11.00.dev17
Yes, using rapids-generate-version in those scripts is unsafe. For non-release builds, it computes a version containing the tag distance (number of commits since last git tag) at runtime. That could return a different answer between package-build time and docs-build or testing time, e.g. if other PRs are merged in between those runs. We should be using doing what legate-boost does... using rapids-generate-version to update the VERSION file, but then always grepping out of it just the {major}.{minor}.{patch} part.
That has its own risks ... it could silently fall back to something else published on the legate conda channel instead of the downloaded packages built in the same CI run. That can be avoided with conda's "strict channel priority"... something that isn't guaranteed to work (yet) for dependency trees involving the rapidsai / rapidsai-nighly channels, but which hopefully will soon: rapidsai/build-planning#84
I thought that changing:
in the docs build and test scripts when installing was a good idea to make things strict, but it seems like it is not actually safe (as noted by @jameslamb).
So, I should change it back (possibly also in one place in legate-dataframe).
A bit unclear if we need to build the
.dev<N>
version at all in that case, but maybe it is nice to just do it anyway.The text was updated successfully, but these errors were encountered: