Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rapids-download-wheels-from-s3 work like rapids-download-conda-from-s3 #64

Open
ajschmidt8 opened this issue Jul 19, 2023 · 1 comment

Comments

@ajschmidt8
Copy link
Member

The rapids-download-wheels-from-s3 script works differently from rapids-download-conda-from-s3 and that has made it difficult to refactor some things in #59.

Their functionality differs in that the conda script extracts the downloads to an arbitrary directory and prints the path whereas the wheel script accepts a path that it should extract to and doesn't print anything.

For the sake of consistency, it would be nice if these two scripts behaved the same. Additionally, if their implementation was consistent, we could likely remove tools/_rapids-download-from-s3 and move its logic to tools/rapids-download-from-s3 (I forget the exact details, but I think that's what I was trying to achieve in #59).

@ajschmidt8
Copy link
Member Author

Linking this comment for additional context: rapidsai/cuxfilter#506 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant