Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Shuffle Inputs Globally in cuGraph-PyG #4606

Closed

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Aug 8, 2024

Previously, inputs were only being shuffled locally. This PR uses NCCL to shuffle inputs across workers for better accuracy. It also exposes an option to disable global shuffling if desired.

Merge after #4641
Closes rapidsai/cugraph-gnn#19

@alexbarghi-nv alexbarghi-nv self-assigned this Aug 8, 2024
@alexbarghi-nv alexbarghi-nv added bug Something isn't working breaking Breaking change labels Aug 8, 2024
@github-actions github-actions bot added the python label Aug 8, 2024
@alexbarghi-nv alexbarghi-nv added non-breaking Non-breaking change and removed breaking Breaking change labels Aug 8, 2024
@alexbarghi-nv alexbarghi-nv added this to the 24.10 milestone Aug 8, 2024
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review August 8, 2024 21:12
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner August 8, 2024 21:12
@alexbarghi-nv alexbarghi-nv requested a review from tingyu66 August 8, 2024 21:16
@alexbarghi-nv alexbarghi-nv added the Blocked Cannot progress due to external reasons label Sep 18, 2024
@alexbarghi-nv alexbarghi-nv changed the base branch from branch-24.10 to branch-24.12 September 30, 2024 16:27
@alexbarghi-nv alexbarghi-nv modified the milestones: 24.10, 24.12 Sep 30, 2024
@alexbarghi-nv alexbarghi-nv removed the Blocked Cannot progress due to external reasons label Sep 30, 2024
@alexbarghi-nv
Copy link
Member Author

This will be refactored and merged into cugraph-gnn instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cuGraph-PyG: The "shuffle" Option Does Not Work Correctly
2 participants