Trending tokens polishes #6331

greg-schrammel · 2024-12-13T13:06:50Z

Fixes APP-####

What changed (plus any additional context for devs)

this pr is base branch is #6276

Trending tokens

integrates farcaster friends

formats price like dexscreener

hook up filters query

Network Switcher

change customize networks hint banner to not show up again after dismissed
add a placeholder on the unpinned section for when all networks are pinned
makes it a bit better when dragging to pin/unpin and the sheet changes height (not sure about the solution, which rn is always having the height account for 1 more network on the unpinned section, so there is no layout shift when dragging between sections)

blocking

Are these timeframes right? I think 30d is missing (from be)
~~I think we need to proxy the farcaster pfp urls, or allowlist the url~~

stuff I dont think is blocking but would like to improve soon

network switcher is fetching/rerendering the trending tokens list every time we change the chain selection, making it lag/drop frames, plan to only update the query on closing the sheet
There are some more small opimizations we can do in the queries but not blocking rn

Screen recordings / screenshots

What to test

brunobar79 · 2024-12-13T14:32:29Z

Launch in simulator or device for 8bdc746

derHowie · 2024-12-13T14:38:30Z

hey @greg-schrammel if these are fixes for the reviews done in the other PR it would be helpful to detail what you fixed here.

brunobar79 · 2024-12-13T16:15:22Z

@greg-schrammel re: farcaster pfp

Using our existing ImgixImage component should do the trick

walmat

good work, some questions for you!

src/components/Discover/TrendingTokens.tsx

src/components/NetworkSwitcher.tsx

src/hooks/useFarcasterAccountForWallets.ts

src/redux/settings.ts

src/resources/trendingTokens/trendingTokens.ts

brunobar79 · 2024-12-13T18:24:56Z

Launch in simulator or device for 7780c5b

maxbbb · 2024-12-13T20:08:00Z

The value -> text formatter is incorrect for anything less than a dollar. Some get rounded way up but all get one additional significant digit (00[3]11 when it should be 00[4]11).

With all these new networks the network switcher full sheet doesn't fit on the screen, not sure how this should be handled given its almost all part of the same DnD section so I don't think you can just wrap the more networks section in a scrollview

brunobar79 · 2024-12-13T20:11:19Z

Just wanted to follow up on @maxbbb while he's right and we do need to fix that when adding more networks, we're only adding one for now. The rest won't be turned ON so I think we can get away with it

greg-schrammel · 2024-12-13T21:38:17Z

src/components/NetworkSwitcher.tsx

+      ? length === 0
+        ? -SEPARATOR_HEIGHT + paddingBottom
+        : 0
+      : length === 0
+        ? ITEM_HEIGHT + paddingBottom
+        : Math.ceil((length + 1) / 2) * (ITEM_HEIGHT + GAP) - GAP + paddingBottom;


got a couple of ideas to clean up a lot of this, and we are gonna need to tweak now that we are gonna support more networks, add scroll etc so gonna do it in a separate pr later

brunobar79 · 2024-12-13T22:42:36Z

Launch in simulator or device for 08cf3b3

derHowie

Did some QA, didn't check pixels since product is doing testflight nits.

Saw 2 things:

derHowie · 2024-12-13T22:59:29Z

Padding looking off here as well, sorry if it's reported elsewhere

derHowie · 2024-12-13T23:05:14Z

Seeing different currency value formatting between token expanded state and the trending rows. Maybe this is intentional but flagging

brunobar79 · 2024-12-14T00:32:54Z

Launch in simulator or device for b6668b3

* remove arrows for price change * fix friend holders display * fix dupes * align and make friends looks better * remove spread * ops --------- Co-authored-by: gregs <[email protected]>

brunobar79 · 2024-12-17T00:26:23Z

Launch in simulator or device for 7e6748a

* convert network accessors to functions * backend networks store * wrote a couple worklet functions to get swaps working * fix other calls * Update package.json * Update ios/Podfile.lock * move all functions into backendNetworksStore and replace calls * refresh podlock * no clue what happened during merge * fix: APP-2021 * fix: APP-2022 * fix build and lint

Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add basic entries * update chain badge assets * alphabetizing imports / mappings * update tokenSearch, default bips * alphabetize and clean up * alphabetize en_US * add explainer text and colors * update simplehash networks * update chainIds and explainer copy * chain IDs * add proper colors * add badges I have access to * add assets to assets folder as well * add assets * comment out other chains * remove badges for other networks * fix ethereum badge assets * idk if podlock is needed * Readd avalanche network type * Add new chains to chainsIdByNetwork mapping --------- Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: jinchung <[email protected]>

* handle raw response from contract call correctly * fix logic to reveal icons

…-tokens-polishes

brunobar79 · 2024-12-18T02:43:31Z

Launch in simulator or device for 1ca3e89

brunobar79 · 2024-12-18T05:38:40Z

Launch in simulator or device for b262be9

* format price for amounts >1 different than fractal amounts * handle >6 figs native value different and show in compact notation to prevent row collision * prevent token symbol from growing beyond what it needs * Update src/components/Discover/TrendingTokens.tsx * remove DebugLayout

brunobar79 · 2024-12-18T20:21:06Z

Launch in simulator or device for 8db73da

* fix spacing between items * Update src/components/Discover/TrendingTokens.tsx

brunobar79 · 2024-12-19T00:49:50Z

Launch in simulator or device for 5b33483

greg-schrammel added 2 commits December 13, 2024 09:50

save

201ed07

align friends pfps

e97f414

greg-schrammel requested review from derHowie and maxbbb December 13, 2024 13:07

fix price change timeframes

eaec25d

fix images

d0f6fcc

greg-schrammel requested a review from walmat December 13, 2024 17:36

walmat reviewed Dec 13, 2024

View reviewed changes

better currency formatting

7ef371a

greg-schrammel commented Dec 13, 2024

View reviewed changes

fix comment

e2e2bec

derHowie requested changes Dec 13, 2024

View reviewed changes

fix network button selecting the wrong one

d4ae43b

derHowie and others added 2 commits December 16, 2024 19:46

fix: tt sort (#6337)

b3d44b3

TT fixes (#6338)

d4dcf1b

* remove arrows for price change * fix friend holders display * fix dupes * align and make friends looks better * remove spread * ops --------- Co-authored-by: gregs <[email protected]>

derHowie and others added 4 commits December 17, 2024 15:36

fix: tt -> swaps nav (#6343)

8a1f3b7

fix missing header height on the sheet (#6315)

5bb2a0f

walmat and others added 7 commits December 17, 2024 17:42

fix undefined size on TextShadow component when switching themes (#6329)

9066a2a

chore: update swaps sdk + use new getWrappedAssetAddress method (#6327)

abf5db5

NFT checker 2.0 (#6293)

2f81bce

Retrieve FID for wallet addresses (#6330)

daaa510

bump iOS and Android to v1.9.50 (#6340)

99e7102

Icons hotfix (#6342)

52c8914

* handle raw response from contract call correctly * fix logic to reveal icons

greg-schrammel changed the base branch from gregs/app-1958-ui-implementation-phase-1 to develop December 17, 2024 20:47

greg-schrammel changed the base branch from develop to gregs/app-1958-ui-implementation-phase-1 December 17, 2024 20:47

greg-schrammel and others added 9 commits December 17, 2024 17:49

Merge branch 'develop' into trending-tokens-polishes

7032e2e

Merge branch 'gregs/app-1958-ui-implementation-phase-1' into trending…

243f741

…-tokens-polishes

chore: merge 6caad4f

909514c

chainId

0ae1a3d

prioritize symbol & not resize selected catergory pill

709279a

discorty screen trending tokens separator

2174043

add remote config to control limit

bfe80fa

remove unused import

6ad09ea

chore: temp hc for review at limit 12

d6f4820

derHowie changed the base branch from gregs/app-1958-ui-implementation-phase-1 to develop December 18, 2024 03:14

derHowie changed the base branch from develop to gregs/app-1958-ui-implementation-phase-1 December 18, 2024 03:15

ibrahimtaveras00 and others added 3 commits December 17, 2024 22:39

Update iOS and Android to v1.9.51 (#6346)

2907fd9

chore: remove unnecessary hc limit

095c9b2

fix: nav to swap from tt row (#6347)

8049dae

walmat added 2 commits December 18, 2024 17:27

Fix spacing to 28px in latest TestFlight version (#6351)

d73864f

* fix spacing between items * Update src/components/Discover/TrendingTokens.tsx

fix network switcher using name instead of label (#6350)

6409fc8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trending tokens polishes #6331

Trending tokens polishes #6331

greg-schrammel commented Dec 13, 2024 •

edited

Loading

brunobar79 commented Dec 13, 2024

derHowie commented Dec 13, 2024

brunobar79 commented Dec 13, 2024

walmat left a comment

brunobar79 commented Dec 13, 2024

maxbbb commented Dec 13, 2024 •

edited

Loading

brunobar79 commented Dec 13, 2024

greg-schrammel Dec 13, 2024

brunobar79 commented Dec 13, 2024

derHowie left a comment

derHowie commented Dec 13, 2024

derHowie commented Dec 13, 2024

brunobar79 commented Dec 14, 2024

brunobar79 commented Dec 17, 2024

brunobar79 commented Dec 18, 2024

brunobar79 commented Dec 18, 2024

brunobar79 commented Dec 18, 2024

brunobar79 commented Dec 19, 2024

Trending tokens polishes #6331

Are you sure you want to change the base?

Trending tokens polishes #6331

Conversation

greg-schrammel commented Dec 13, 2024 • edited Loading

What changed (plus any additional context for devs)

Trending tokens

Network Switcher

blocking

stuff I dont think is blocking but would like to improve soon

Screen recordings / screenshots

What to test

brunobar79 commented Dec 13, 2024

derHowie commented Dec 13, 2024

brunobar79 commented Dec 13, 2024

walmat left a comment

Choose a reason for hiding this comment

brunobar79 commented Dec 13, 2024

maxbbb commented Dec 13, 2024 • edited Loading

brunobar79 commented Dec 13, 2024

greg-schrammel Dec 13, 2024

Choose a reason for hiding this comment

brunobar79 commented Dec 13, 2024

derHowie left a comment

Choose a reason for hiding this comment

derHowie commented Dec 13, 2024

derHowie commented Dec 13, 2024

brunobar79 commented Dec 14, 2024

brunobar79 commented Dec 17, 2024

brunobar79 commented Dec 18, 2024

brunobar79 commented Dec 18, 2024

brunobar79 commented Dec 18, 2024

brunobar79 commented Dec 19, 2024

greg-schrammel commented Dec 13, 2024 •

edited

Loading

maxbbb commented Dec 13, 2024 •

edited

Loading