-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Until' column to contributors index #303
base: main
Are you sure you want to change the base?
Add 'Until' column to contributors index #303
Conversation
a30b515
to
8daf9f8
Compare
@@ -5,9 +5,8 @@ def test_index | |||
get :index | |||
assert_response :success | |||
|
|||
assert_select 'span.listing-total', 'Showing 5 releases' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated below.
5df299d
to
499e068
Compare
@@ -4,34 +4,53 @@ class RepoTest < ActiveSupport::TestCase | |||
test '#sync_ranks' do | |||
Repo.new.send(:sync_ranks) | |||
|
|||
{jeremy: 1, david: 2, jose: 3, xavier: 3, vijay: 3}.each do |c, r| | |||
{jeremy: 1, david: 2, jose: 2, xavier: 4, vijay: 4}.each do |c, r| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a bug. Not introduced here cause it can be observed on the official site.
I think it makes more sense that if multiple contributors share a rank the next contributor should be assigned the next rank i.e. this should be:
{jeremy: 1, david: 2, jose: 2, xavier: 4, vijay: 4}.each do |c, r| | |
{jeremy: 1, david: 2, jose: 2, xavier: 3, vijay: 3}.each do |c, r| |
499e068
to
dd397c9
Compare
Hey, thanks for proposing this. I am not 100% sure I like the idea. Reason is, the spirit to this website is to give credit to people and pay tribute to them with public recognition. It is less about "data". I'd even consider dropping "Since". Let us think about it. |
Closes #289
QA (with synced Rails repo)
dc/sync
works as expected with a fresh DB