Terminal background not detected properly in Lefthook

[brynary]

What happened?

When run via Lefthook, Qlty is rendering a black background into a light colored terminal.

Output when running through lefthook

Output when running directly in terminal

Relevant Files

lefthook.yml

pre-commit:
  commands:
    check:
      run: qlty check -a
      stage_fixed: true
    smells:
      run: qlty smells -a
      stage_fixed: true
commit-msg:
  commands:
    lint:
      run: pnpm exec commitlint -e

[brynary]

This seems like it may be due to an interaction Lefthook and VSCode. Qlty tries to figure out if it is on a light terminal or dark terminal using this code:

qlty/qlty-cli/src/ui/highlight.rs

Lines 18 to 27 in f735309

	let background = match termbg::rgb(timeout) {
	Ok(rgb) => TermbgToSyntectColorAdapter::adapt_color(rgb),
	Err(_) => Color::BLACK,
	};
	let theme_name = match termbg::theme(timeout) {
	Ok(Theme::Light) => "InspiredGitHub",
	Ok(Theme::Dark) => "base16-eighties.dark",
	Err(_) => "base16-eighties.dark",
	};

We are using termbg to do the detection. It looks like termbg has to add support for different kinds of terminals: https://github.com/dalance/termbg?tab=readme-ov-file#verified-terminals

Maybe VSCode is supported by termbg, but Lefthook is behaving differently causing termbg to not be able to detect it.

[brynary]

@lamualfa -- To keep things organized, I split the prior GitHub issue into two items: This bug for the terminal background problem, and a Feature Request for enhancing the qlty smells to return non-zero exit codes when it finds issues.