-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supported_platforms
for plugins
#1220
Comments
It occurred to me that |
The way we handle that is with multiple driver definitions. Driver definitions can target version ranges of plugins So if we defined the supported platforms data at the driver level instead of the plugin level then you could model this (One plugin has one or more drivers) |
@brynary you wrote:
I'm assuming you meant to write that the planner should skip the plugin when running on an unsupported platform? |
Certain plugins may not be compatible with all platforms that we run on. For example, we have identified issues with Hadolint on MacOS, and we have identified issues with swiftlint on non-MacOS systems.
Add a
supported_platforms
array key to the plugin definition:Valid array values are
"macos"
,"linux"
, and"windows"
.If
supported_platforms
is empty, treat it as all platforms. Ifsupported_platforms
is not blank:qlty init
should only enable the plugin if it is on a supported platform.info!
)The text was updated successfully, but these errors were encountered: