Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow ClassVar and Final in TypedDict and NamedTuple #18281

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Do not allow ClassVar and Final in TypedDict and NamedTuple #18281

merged 5 commits into from
Dec 12, 2024

Conversation

sobolevn
Copy link
Member

Closes #18220

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
JukkaL
JukkaL reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left questions about functional forms.

test-data/unit/check-namedtuple.test Show resolved Hide resolved
test-data/unit/check-typeddict.test Show resolved Hide resolved
@sobolevn
Copy link
Member Author

Thanks, addressed! 👍

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

JukkaL
JukkaL approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now!

@JukkaL JukkaL merged commit bec5cad into master Dec 12, 2024
19 checks passed
@JukkaL JukkaL deleted the issue-18220 branch December 12, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow ClassVar and Final qualifiers in TypedDict and NamedTuple items
2 participants
@sobolevn @JukkaL