Wrap notification text #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastinas
requested changes
Jul 17, 2024
Signed-off-by: Jonas Dujava <[email protected]>
|
Is there currently some usecase where the text wrapping is undesirable? Focusing mainly on To be honest, I am not really confident that I would come up with a nice way to toggle it (and consistently apply necessary changes to other projects). Leaving it to someone more competent would be ideal :). |
jdujava
force-pushed
the
notification-wrap
branch
from
6f5bc82 to
24ef618
Compare
|
One approach to implement this would be to duplicate the notification area/code for a wrapped version and then check the uses of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable wrapping of
notification_text. Also add small left/right margins.Partially fixes pwmt/zathura#624.