Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Improve readability in AnnouncementBanner #275

Open
1 task done
ivangonzalezacuna opened this issue Mar 26, 2024 · 5 comments
Open
1 task done

🚀 Feature: Improve readability in AnnouncementBanner #275

ivangonzalezacuna opened this issue Mar 26, 2024 · 5 comments
Labels
enhancement New feature or request help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@ivangonzalezacuna
Copy link

🔖 Feature description

We are using the announcements plugin for a while. Some of our developer have suggested that the banner colors are not the best regarding readability, specially in the light mode. We've seen this PR in the past: K-Phoen/backstage-plugin-announcements#154, but it wasn't merged there, and doesn't seem to be here either. Is this something that would make sense?

🎤 Context

Some of our developer have complained about some readability issues in the banners, specially in the light theme.

✌️ Possible Implementation

As mentioned above, a solution like the one described in K-Phoen/backstage-plugin-announcements#154 could be a nice one.

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@ivangonzalezacuna ivangonzalezacuna added the enhancement New feature or request label Mar 26, 2024
@kurtaking
Copy link
Contributor

hey @ivangonzalezacuna, thanks for reaching out. I posted on that issue in the past.

Happy to review a PR if you would like to contribute the functionality.

@kurtaking kurtaking added the help wanted Anyone is welcome to open a pull request to fix this issue label Mar 31, 2024
@kurtaking
Copy link
Contributor

Maybe that is something @sravanireddy115 can help with?

@ivangonzalezacuna
Copy link
Author

hey @ivangonzalezacuna, thanks for reaching out. I K-Phoen/backstage-plugin-announcements#154 (comment) in the past.
Happy to review a PR if you would like to contribute the functionality.

Hi! Unfortunately I don't have much time to try that out at the moment, so it would be nice if somebody else has some time to check this out. I guess some of the work can be easily done by the suggestion in that issue, but I'm not entirely sure.

@kurtaking kurtaking pinned this issue Apr 29, 2024
@kurtaking kurtaking unpinned this issue Aug 19, 2024
@jmezach
Copy link

jmezach commented Sep 5, 2024

Just a thought here, but would it make sense to replace the banner entirely in favour of the new Notifications support in Backstage itself?

@kurtaking
Copy link
Contributor

Just a thought here, but would it make sense to replace the banner entirely in favour of the new Notifications support in Backstage itself?

@jmezach, its very likely the notifications plugin could replace announcements altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Development

No branches or pull requests

3 participants